Opened 10 years ago
Closed 10 years ago
#13763 closed defect (fixed)
Minkowski subtraction
Reported by: | Volker Braun | Owned by: | mhampton |
---|---|---|---|
Priority: | major | Milestone: | sage-5.7 |
Component: | geometry | Keywords: | |
Cc: | Dima Pasechnik | Merged in: | sage-5.7.beta2 |
Authors: | Volker Braun | Reviewers: | Dmitrii Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #11763, #12193 | Stopgaps: |
Description (last modified by )
This patch implements the Minkowski difference and some misc. bugfixes (Did you know that CartesianProduct
with generators silently gives the wrong answer? #13764)
Apply trac_13763_minkowski_difference.patch, trac_13763_minkowski_sum_decompositions.patch
Attachments (2)
Change History (12)
comment:1 Changed 10 years ago by
Dependencies: | → #11763 |
---|---|
Status: | new → needs_review |
comment:2 Changed 10 years ago by
Cc: | Dima Pasechnik added |
---|---|
Description: | modified (diff) |
comment:3 Changed 10 years ago by
comment:4 Changed 10 years ago by
Dependencies: | #11763 → #11763, #12193 |
---|
Patch doesn't commute with #12193, added to the dependencies even though its functionally independent.
comment:5 Changed 10 years ago by
Description: | modified (diff) |
---|
While we are at it, I added some code to list all decompositions of a polygon into the Minkowski sum of two smaller polygons.
comment:6 Changed 10 years ago by
Status: | needs_review → needs_work |
---|
sage -t -long "devel/sage-main/sage/geometry/polyhedron/base_ZZ.py" ********************************************************************** File "/usr/local/src/sage/sage-5.6.beta2/devel/sage-main/sage/geometry/polyhedron/base_ZZ.py", line 402: sage: [ len(square.dilation(i).Minkowski_decompositions()) for i in range(Integer(6)) ] Exception raised: Traceback (most recent call last): File "/usr/local/src/sage/sage-5.6.beta2/local/bin/ncadoctest.py", line 1231, in run_one_test self.run_one_example(test, example, filename, compileflags) File "/usr/local/src/sage/sage-5.6.beta2/local/bin/sagedoctest.py", line 38, in run_one_example OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags) File "/usr/local/src/sage/sage-5.6.beta2/local/bin/ncadoctest.py", line 1172, in run_one_example compileflags, 1) in test.globs File "<doctest __main__.example_12[7]>", line 2, in <module> for i in range(Integer(6)) ] File "/usr/local/src/sage/sage-5.6.beta2/local/lib/python/site-packages/sage/geometry/polyhedron/base.py", line 2402, in dilation base_ring=self.parent()._coerce_base_ring(scalar.parent())) AttributeError: 'int' object has no attribute 'parent'
looks like there is int
somewhere where one should have ZZ
instead...
Changed 10 years ago by
Attachment: | trac_13763_minkowski_sum_decompositions.patch added |
---|
Updated patch
comment:7 Changed 10 years ago by
Thanks, fixed. It should have just been _coerce_base_ring(scalar)
, the method is smart enough to deal with ZZ
and int
.
comment:8 Changed 10 years ago by
Status: | needs_work → positive_review |
---|
comment:9 Changed 10 years ago by
Reviewers: | → Dmitrii Pasechnik |
---|
comment:10 Changed 10 years ago by
Merged in: | → sage-5.7.beta2 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
I get
any idea why? Seems you might want to rebase it, perhaps adding #13638 as a dependency (hunk 4 fuzz happens with and without #13638 - although with different offsets.)