Opened 8 years ago

Closed 7 years ago

#13738 closed enhancement (fixed)

wrap debug output functions from GiNaC

Reported by: burcin Owned by: burcin
Priority: minor Milestone: sage-5.11
Component: symbolics Keywords:
Cc: Merged in: sage-5.11.beta3
Authors: Burcin Erocal Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Attached patch provides access to dbgprint() and dbgprintree() methods from GiNaC.

Apply trac_13738-dbgprint.patch and trac_13738-review.patch.

Attachments (2)

trac_13738-dbgprint.patch (2.4 KB) - added by burcin 8 years ago.
trac_13738-review.patch (1.6 KB) - added by kcrisman 7 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by burcin

comment:1 Changed 8 years ago by burcin

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by kcrisman

This looks pretty straightforward to review, and patchbot likes it, though of course we aren't actually testing.

comment:3 Changed 7 years ago by kcrisman

  • Description modified (diff)
  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to positive_review

comment:4 Changed 7 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from positive_review to needs_work

The output is sent to stderr, so the examples are not doctested.

This used to be a good excuse, but the new doctesting framework catches stderr too. So you can and should add doctests.

comment:5 follow-up: Changed 7 years ago by kcrisman

Can you point us to an example, or is just a normal doctest sufficient?

Last edited 7 years ago by kcrisman (previous) (diff)

comment:6 in reply to: ↑ 5 Changed 7 years ago by jdemeyer

Replying to kcrisman:

is just a normal doctest sufficient?

Indeed.

Changed 7 years ago by kcrisman

comment:7 Changed 7 years ago by kcrisman

  • Status changed from needs_work to positive_review

Is this sufficient? You can put to 'needs work' if not.

comment:8 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.11.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.