Opened 10 years ago

Closed 9 years ago

#13738 closed enhancement (fixed)

wrap debug output functions from GiNaC

Reported by: Burcin Erocal Owned by: Burcin Erocal
Priority: minor Milestone: sage-5.11
Component: symbolics Keywords:
Cc: Merged in: sage-5.11.beta3
Authors: Burcin Erocal Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Attached patch provides access to dbgprint() and dbgprintree() methods from GiNaC.

Apply trac_13738-dbgprint.patch and trac_13738-review.patch.

Attachments (2)

trac_13738-dbgprint.patch (2.4 KB) - added by Burcin Erocal 10 years ago.
trac_13738-review.patch (1.6 KB) - added by Karl-Dieter Crisman 9 years ago.

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by Burcin Erocal

Attachment: trac_13738-dbgprint.patch added

comment:1 Changed 10 years ago by Burcin Erocal

Status: newneeds_review

comment:2 Changed 9 years ago by Karl-Dieter Crisman

This looks pretty straightforward to review, and patchbot likes it, though of course we aren't actually testing.

comment:3 Changed 9 years ago by Karl-Dieter Crisman

Description: modified (diff)
Reviewers: Karl-Dieter Crisman
Status: needs_reviewpositive_review

comment:4 Changed 9 years ago by Jeroen Demeyer

Description: modified (diff)
Status: positive_reviewneeds_work

The output is sent to stderr, so the examples are not doctested.

This used to be a good excuse, but the new doctesting framework catches stderr too. So you can and should add doctests.

comment:5 Changed 9 years ago by Karl-Dieter Crisman

Can you point us to an example, or is just a normal doctest sufficient?

Last edited 9 years ago by Karl-Dieter Crisman (previous) (diff)

comment:6 in reply to:  5 Changed 9 years ago by Jeroen Demeyer

Replying to kcrisman:

is just a normal doctest sufficient?

Indeed.

Changed 9 years ago by Karl-Dieter Crisman

Attachment: trac_13738-review.patch added

comment:7 Changed 9 years ago by Karl-Dieter Crisman

Status: needs_workpositive_review

Is this sufficient? You can put to 'needs work' if not.

comment:8 Changed 9 years ago by Jeroen Demeyer

Merged in: sage-5.11.beta3
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.