Opened 7 years ago

Closed 7 years ago

#13729 closed defect (fixed)

Update pynac to 0.2.6

Reported by: burcin Owned by: burcin
Priority: major Milestone: sage-5.9
Component: symbolics Keywords: pynac
Cc: kcrisman, benjaminfjones Merged in: sage-5.9.beta0
Authors: Burcin Erocal, Sebastien Gouezel Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #13262 Stopgaps:

Description (last modified by fbissey)

Pynac 0.2.6 is out with fixes for

  • #13609: normalization of content in GF(2^k) leads to infinite loop
  • #13587: invalid cancellation of infinities
  • #13262: Fix printing of parenthesis around exponents of power objects.

Tarball is available here:

http://pynac.org/download/pynac-0.2.6.tar.bz2

New spkg: http://boxen.math.washington.edu/home/jpflori/pynac-0.2.6.spkg

Change History (17)

comment:1 Changed 7 years ago by kcrisman

  • Cc kcrisman added

comment:2 follow-up: Changed 7 years ago by kcrisman

Btw, do any of these need to be reported upstream?

comment:3 Changed 7 years ago by fbissey

burcin is pynac upstream, do you mean the ginac upstream from pynac?

comment:4 in reply to: ↑ 2 Changed 7 years ago by burcin

Replying to kcrisman:

Btw, do any of these need to be reported upstream?

If upstream = GiNaC: No, these are all messes we created. :) GiNaC does not have coefficients in GF(2) or infinities. Our printing methods are also different.

comment:5 Changed 7 years ago by jpflori

I've uploaded an updated spkg using the tarball Burcin provided at http://boxen.math.washington.edu/home/jpflori/pynac-0.2.6.spkg

I've not run the whole testsuite yet, only the symbolic directory, but there seems to be problems left with parenthesis around exponents (#13262), let's hope I messed something.

comment:6 Changed 7 years ago by jpflori

Ok, my bad, my patch queue was not completely pushed :)

comment:7 Changed 7 years ago by benjaminfjones

  • Cc benjaminfjones added

comment:8 Changed 7 years ago by fbissey

What is missing for this ticket to be positively reviewed? Things works fine for me provided that I apply #13262 to fix the latex output in doctests.

comment:9 Changed 7 years ago by fbissey

  • Status changed from new to needs_review

comment:10 Changed 7 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

I am putting this to positive review. It can go in with #13262 independently of the other 2 as far as I can see.

comment:11 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.8 to sage-5.9

comment:12 Changed 7 years ago by jdemeyer

  • Status changed from positive_review to needs_info

What's there to merge?

comment:13 Changed 7 years ago by fbissey

  • Description modified (diff)
  • Status changed from needs_info to needs_review

It is indeed missing from the summary. Jean-Pierre Flori made a spkg. Now linked in the summary.

comment:14 Changed 7 years ago by fbissey

  • Status changed from needs_review to positive_review

comment:15 Changed 7 years ago by jdemeyer

  • Status changed from positive_review to needs_work
sage -t devel/sage/sage/symbolic/relation.py
**********************************************************************
File "devel/sage/sage/symbolic/relation.py", line 247, in sage.symbolic.relation
Failed example:
    latex(x^(3/5) >= pi)
Expected:
    x^{\left(\frac{3}{5}\right)} \geq \pi
Got:
    x^{\frac{3}{5}} \geq \pi
**********************************************************************
sage -t devel/sage/sage/symbolic/expression.pyx
**********************************************************************
File "devel/sage/sage/symbolic/expression.pyx", line 627, in sage.symbolic.expression.Expression._latex_
Failed example:
    latex((x^(pi+1))^e)
Expected:
    {\left(x^{{\left(\pi + 1\right)}}\right)}^{e}
Got:
    {\left(x^{\pi + 1}\right)}^{e}
**********************************************************************

comment:16 Changed 7 years ago by fbissey

  • Dependencies set to #13262
  • Status changed from needs_work to positive_review

Yes. It needs to be applied at the same time as #13262 which does fix that. Not sure why it was split. Sorry for losing your time by not updating the ticket description clearly enough.

comment:17 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.9.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.