Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#13717 closed enhancement (fixed)

Upgrade to sagenb 0.10.4

Reported by: jason Owned by: tbd
Priority: major Milestone: sage-5.7
Component: packages: standard Keywords:
Cc: kini, jhpalmieri Merged in: sage-5.7.beta0
Authors: Jason Grout, Keshav Kini Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #13504, #13678 Stopgaps:

Description (last modified by kini)

This is a relatively minor upgrade. It contains a few bugfixes, plus packaging one more dependency to take care of the problem at #12719/#10353. It also merges patches from #13504 and #13678, so those need to be merged simultaneously with this ticket.

SPKG at http://wstein.org/home/keshav/files/sagenb-0.10.4.spkg

Here's a short log of the commits:

[2] fs@erdos ~/src/sagenb $ git log --oneline --simplify-merges 0.10.2..0.10.4 | cat
4648948 (HEAD, tag: refs/tags/0.10.4, refs/remotes/upstream/master, refs/heads/master) Version bump to 0.10.4
64bcd91 (refs/remotes/origin/master, refs/remotes/origin/HEAD) Link the new HACKING.rst to the Sage docs
2638c05 Update installation README
ae02bff Merge remote-tracking branches '@jhpalmieri/mathmode_v2' and '@jhpalmieri/latex-macros'; commit '4696154' from @robertwb
4696154 (refs/remotes/robertwb/master) Fix for sage #13678, allow tab completion of matrix constructor.
9cf8ac7 (refs/remotes/jhpalmieri/latex-macros) sage.misc.latex_macros: do not evaluate anything on startup. See trac #13504
5985758 (refs/remotes/jhpalmieri/mathmode_v2, refs/heads/mathmode_v2) Reinstate 'is_html_markup'.
e11c433 (refs/heads/gh-126) Merge pull request #127 from gvol/master
4396d0f Ignore Mac metadata files when uploading a zip
6a42da6 Merge pull request #115 from jasongrout/openid-import
679e43f Fix the import for openid, as per http://flask.pocoo.org/docs/extensions/#using-extensions
c384b4e (tag: refs/tags/0.10.3) Update sagenb version number to 0.10.3
96a3732 Package zope.interface, which is required for twisted
0ae273b Merge pull request #66 from rmartinjak/usermgmt
c65fccb Merge branch 'master' into usermgmt
d026aac two small cosmetic changes
460ef01 Merge branch 'master' into usermgmt
1a94141 Merge branch 'master' into usermgmt
0d616c4 Merge branch 'master' into usermgmt
6bf3398 Merge branch 'master' into usermgmt
54204e5 Merge branch 'master' into usermgmt
cca8fd3 Merge branch 'master' into usermgmt
759a99b Merge branch 'master' into usermgmt
a0e3e7d Merge branch 'master' into usermgmt
e2beade added granting/revoking of admin privileges
22c6424 added possibility to delete users
97dd5b8 distinct URI for suspend/delete
150ac05 Fix admin permission checking
cf421ee Merge pull request #92 from alfredoport/master
f65b291 Update sagenb/notebook/notebook.py
3280031 Merge pull request #97 from jhpalmieri/mathmode
f1f1a9f (refs/remotes/jhpalmieri/mathmode) Fix introspection and live documentation in the notebook
7aadeb3 With introspection and live documentation in the notebook, fix spurious \(,\) and \[,\] pairs
be5eb3c Merge pull request #99 from kcrisman/patch-2
37d598c mmarco's idea to solve "invalid username" error
adcd348 Merge pull request #101 from rmartinjak/issue-47
4498cef create default users if "admin" doesn't exist
50c3130 Merge pull request #104 from lukas-lansky/graph-editor-jQuery
aa29f96 jQuery reference repair in graph_editor

Change History (19)

comment:1 Changed 6 years ago by jason

  • Description modified (diff)

comment:2 Changed 6 years ago by jason

It looks like we have two failing doctests:

sage -t  -force_lib "devel/sagenb-main/sagenb/misc/sphinxify.py"
**********************************************************************
File "/Users/grout/sage-trees/sage-5.4/devel/sagenb-main/sagenb/misc/sphinxify.py", line 57:
    sage: sphinxify('`x=y`')
Expected:
    '\n<div class="docstring">\n    \n  <p><span class="math">\\(x=y\\)</span></p>\n\n\n</div>'
Got:
    '\n<div class="docstring">\n    \n  <p><span class="math">x=y</span></p>\n\n\n</div>'
**********************************************************************
1 items had failures:
   1 of   9 in __main__.example_1
***Test Failed*** 1 failures.
For whitespace errors, see the file /Users/grout/.sage//tmp/sphinxify_78034.py
	 [3.1 s]
sage -t  -force_lib "devel/sagenb-main/sagenb/misc/support.py"
**********************************************************************
File "/Users/grout/sage-trees/sage-5.4/devel/sagenb-main/sagenb/misc/support.py", line 246:
    sage: D = docstring("r.lm", globs=globals())
Exception raised:
    Traceback (most recent call last):
      File "/Users/grout/sage-trees/sage-5.4/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/grout/sage-trees/sage-5.4/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/grout/sage-trees/sage-5.4/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_4[3]>", line 1, in <module>
        D = docstring("r.lm", globs=globals())###line 246:
    sage: D = docstring("r.lm", globs=globals())
      File "/Users/grout/sage-trees/sage-5.4/devel/sagenb/sagenb/misc/support.py", line 275, in docstring
        return html_markup(s.decode('utf-8'))
      File "/Users/grout/sage-trees/sage-5.4/devel/sagenb/sagenb/misc/support.py", line 280, in html_markup
        return sphinxify(s)
      File "/Users/grout/sage-trees/sage-5.4/devel/sagenb/sagenb/misc/sphinxify.py", line 79, in sphinxify
        filed.write(docstring)
    UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 370: ordinal not in range(128)
**********************************************************************
1 items had failures:
   1 of   5 in __main__.example_4
***Test Failed*** 1 failures.

jhpalmieri, these both seem to be in your area of expertise. What do you think?

comment:3 Changed 6 years ago by jason

  • Status changed from new to needs_review

comment:4 Changed 6 years ago by jason

  • Status changed from needs_review to needs_work

comment:5 Changed 6 years ago by jason

(I got those failures above on 5.4 using sage -t -sagenb. Is the problem that I was working on 5.4?

comment:6 Changed 6 years ago by jason

I've moved discussion of these failing doctests back over to github: https://github.com/sagemath/sagenb/issues/112

comment:7 Changed 6 years ago by fbissey

This now blocks #10353 is the sphinx problem the only thing holding the upgrade?

comment:8 Changed 6 years ago by kini

I guess we should probably merge gh-96 for #13504 and gh-125 for #13678, along with a fix for the above mentioned sphinx issues, into 0.10.4 and update this ticket with a new spkg.

comment:9 Changed 6 years ago by kini

  • Authors changed from Jason Grout to Jason Grout, Keshav Kini
  • Dependencies set to #13504, #13678
  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:10 Changed 6 years ago by kini

Please test! :)

comment:11 Changed 6 years ago by jason

  • Summary changed from Upgrade to sagenb 0.10.3 to Upgrade to sagenb 0.10.4

comment:12 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work
  • Work issues set to HTTP 404
jdemeyer@sage:/home/release/sage-5.7.beta0$ wget http://wstein.org/home/keshav/sagenb-0.10.4.spkg
--11:07:30--  http://wstein.org/home/keshav/sagenb-0.10.4.spkg
           => `sagenb-0.10.4.spkg'
Resolving wstein.org... 128.208.160.191, 128.208.160.197
Connecting to wstein.org|128.208.160.191|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
11:07:30 ERROR 404: Not Found.

comment:13 Changed 6 years ago by kini

  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Work issues HTTP 404 deleted

D'oh. Sorry about that.

comment:14 Changed 6 years ago by jdemeyer

I won't formally review this, but it builds and passes doctests without problems on the buildbots.

comment:15 Changed 6 years ago by kini

Glad to hear it!

comment:16 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Packaging of the sagenb point release looks good to me.

comment:17 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.7.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:18 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.6 to sage-5.7

comment:19 Changed 6 years ago by kini

Followup: #14330

Note: See TracTickets for help on using tickets.