Opened 7 years ago

Closed 7 years ago

#13702 closed task (fixed)

Fix path in SAGE_ROOT/spkg/README.txt

Reported by: pipedream Owned by: mvngu
Priority: minor Milestone: sage-5.5
Component: documentation Keywords:
Cc: Merged in: sage-5.5.rc1
Authors: Jan Groenewald Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by kcrisman)

SAGE_ROOT/spkg/README.txt refers to SAGE_ROOT/sage/doc/output/html/en/developer/index.html but the path should be SAGE_ROOT/devel/sage/doc/output/html/en/developer/index.html

Apply trac_13702.patch to the root repository.

Attachments (2)

README.txt.patch (497 bytes) - added by pipedream 7 years ago.
trac_13702.patch (738 bytes) - added by kcrisman 7 years ago.

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by pipedream

comment:1 Changed 7 years ago by pipedream

  • Description modified (diff)

comment:2 Changed 7 years ago by kcrisman

  • Authors set to Jan Groenewald
  • Reviewers set to Karl-Dieter Crisman
  • Status changed from new to needs_review

You are right, and this fix is okay. The patch is not a standard one, though, so I'm uploading that. Please make sure it applies and does what you want, then switch to positive review.

comment:3 Changed 7 years ago by kcrisman

You can also manually edit the author to be you and upload that patch :-)

Changed 7 years ago by kcrisman

comment:4 Changed 7 years ago by kcrisman

  • Status changed from needs_review to positive_review

Let's do this thing. Jan, I made you be the author of the patch, since you are.

comment:5 Changed 7 years ago by pipedream

Thanks Karl, Somehow I missed these comments in the last few weeks and only saw it now. The patch looks good. How can I produce the standard patches? Regards, Jan

comment:6 Changed 7 years ago by kcrisman

  • Description modified (diff)

Patchbot, apply trac_13702.patch to the root repository. (Hopefully that will work.)

Jan, you can go into SAGE_ROOT and make your changes, then do

./sage -hg ci
<it should show your changes, then dump you into an editor to produce a commit message>
./sage -hg export tip > /path/to/filename.patch

or you can use hg_root to do things in this repository.

comment:7 Changed 7 years ago by pipedream

Thanks, I think the only difference was that I used hg instead of sage -hg. I will check the next time I export a patch.

comment:8 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.5.rc1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.