Changes between Version 3 and Version 5 of Ticket #13688


Ignore:
Timestamp:
Feb 20, 2013, 4:00:06 PM (10 years ago)
Author:
Travis Scrimshaw
Comment:

Replying to andrew.mathas:

Can you add a doctest for testing for this?

Done. I expanded on the example I gave in the description.

Presumably it showed up in a real class.

In partition.py after #13605 is applied (of course without this patch).

Happy for you to set this to a positive review once that's done.

Also done. Thank you for reviewing this.

Best,
Travis

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13688

    • Property Status changed from needs_review to positive_review
    • Property Keywords days45 added
    • Property Reviewers changed from to Andrew Mathas
  • Ticket #13688 – Description

    v3 v5  
    3131}}}
    3232
    33 This seems to be caused by not checking if the parent class has a `cardinality()` function implemented, and just overriding it with `_cardinality_from_list()` (which takes no [optional] parameters).
    34 
    35 NOTE: The failure will '''only''' show up while running doctests using `sage -t`, not while running sage.
     33This seems to be caused by not checking if the parent class has a `cardinality()` function implemented, and just overriding it with `_cardinality_from_list()` (which takes no [optional/keyword] parameters).