Opened 9 years ago

Closed 8 years ago

#13686 closed defect (fixed)

wrong function tested in interface/r.py

Reported by: fbissey Owned by: was
Priority: trivial Milestone: sage-5.12
Component: interfaces Keywords: beginner
Cc: kcrisman Merged in: sage-5.12.beta5
Authors: Frédéric Chapoton Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Stumbled upon that while analizing sage-on-gentoo test failures. In r.py there are two functions r.version and r_version. But they have the same doctest...

def r_version():

""" Return the R version.

EXAMPLES

sage: r.version() ((2, 14, 0), 'R version 2.14.0 (2011-10-31)')

""" return r.version()

Sure r_version returns r.version but r_version should be tested not r.version again surely.

Attachments (1)

trac_13686_r_version_cleanup.patch (992 bytes) - added by chapoton 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by kcrisman

  • Cc kcrisman added
  • Keywords beginner added

Changed 8 years ago by chapoton

comment:2 Changed 8 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Status changed from new to needs_review

done, needs review

comment:3 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:4 Changed 8 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

I don't know if it makes any sense to have those two functions available, nor to have r_version exported into the global namespace, but this patch still makes sense :-P

Nathann

comment:5 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.12.beta5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.