#13681 closed defect (fixed)
fix issues with SAGE_TMP
| Reported by: | vbraun | Owned by: | leif |
|---|---|---|---|
| Priority: | blocker | Milestone: | sage-5.4 |
| Component: | scripts | Keywords: | |
| Cc: | jdemeyer | Merged in: | sage-5.4.rc4 |
| Authors: | Jeroen Demeyer | Reviewers: | Volker Braun |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | #13631 | Stopgaps: |
Status badges
Description (last modified by )
#13579 changed SAGE_TMP. There are some places with less-than-ideal handling of SAGE_TMP that are broken in the process.
sage-cleanerhardcodes '.../temp/...' but thats not correct any more.- Many doctests use SAGE_TMP+'foo.bar'. The new SAGE_TMP doesn't end in a backslash any more. Using
os.path.joinwould have saved the day.
Follow-up: #13147
Apply
- 13681_scripts.patch to the
SAGE_ROOT/local/binrepo - 13681_sagelib.patch to the Sage library
Attachments (3)
Change History (19)
comment:1 Changed 8 years ago by
- Milestone changed from sage-5.5 to sage-5.4
- Priority changed from major to blocker
Changed 8 years ago by
comment:2 follow-up: ↓ 3 Changed 8 years ago by
comment:3 in reply to: ↑ 2 ; follow-up: ↓ 8 Changed 8 years ago by
Replying to jhpalmieri:
Would you consider merging #13147 into 5.4, and then rebasing this on top of that?
Why? I don't see the advantage.
comment:4 follow-up: ↓ 7 Changed 8 years ago by
I could incorporate all the changes from #13147 except for the "lazy string" part.
Changed 8 years ago by
comment:5 Changed 8 years ago by
- Description modified (diff)
comment:6 Changed 8 years ago by
- Status changed from new to needs_review
comment:7 in reply to: ↑ 4 Changed 8 years ago by
comment:8 in reply to: ↑ 3 Changed 8 years ago by
Replying to jdemeyer:
Replying to jhpalmieri:
Would you consider merging #13147 into 5.4, and then rebasing this on top of that?
Why? I don't see the advantage.
One advantage would have been so #13147 wouldn't need rebasing, and it also solved some of the same issues. But now I guess it will need rebasing anyway.
comment:9 follow-up: ↓ 11 Changed 8 years ago by
Doctesting still litters files around than don't get deleted because SAGE_TESTDIR is not a the expected DOT_SAGE/tmp/hostname/pid/.... I'll attach a patch to fix this.
Positive review to all the other patches.
comment:10 Changed 8 years ago by
- Description modified (diff)
- Reviewers set to Volker Braun
comment:11 in reply to: ↑ 9 Changed 8 years ago by
comment:12 Changed 8 years ago by
Volker, could you agree with not merging your patch here? I feel that the chance of stuff breaking is too big to risk merging it.
comment:13 Changed 8 years ago by
- Status changed from needs_review to positive_review
I'll attach the SAGE_TESTDIR stuff to the followup ticket, then.
comment:14 Changed 8 years ago by
- Description modified (diff)
comment:15 Changed 8 years ago by
- Merged in set to sage-5.4.rc4
- Resolution set to fixed
- Status changed from positive_review to closed
comment:16 Changed 8 years ago by
- Dependencies set to #13631
Would you consider merging #13147 into 5.4, and then rebasing this on top of that?