Opened 7 years ago

Closed 7 years ago

#13635 closed defect (fixed)

sage.isgci.update_db is broken

Reported by: ncohen Owned by: tbd
Priority: major Milestone: sage-5.5
Component: graph theory Keywords:
Cc: jdemeyer, dcoudert Merged in: sage-5.5.beta2
Authors: Nathann Cohen Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Ticket #13123 touched many files, including graphs.isgci, and broke a method on the way. An untested method -- because it requires internet -- but that should be fixed quickly because of political reasons : Ernst from ISGCI wants to make an announcement about his new version of the database, would like to tak about Sage on the way, and it's not exactly a good advertisement if we say "here's how you can update the db" when the method is broken :-P

Nathann

Attachments (1)

trac_13635.patch (627 bytes) - added by ncohen 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by ncohen

comment:1 Changed 7 years ago by ncohen

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by ncohen

  • Cc jdemeyer added; jdemyer removed
  • Component changed from PLEASE CHANGE to graph theory
  • Type changed from PLEASE CHANGE to defect

comment:3 Changed 7 years ago by dcoudert

Well, I'm able to safely install the patch, but how can I test that it solves the issue?

comment:4 Changed 7 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

Apparently this patch solves the problem.

sage: graph_classes.update_db()
Database downloaded
sage: 

comment:5 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.5.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.