Opened 9 years ago
Closed 8 years ago
#13610 closed enhancement (fixed)
Make sage -t --debug trigger on an incorrect doctest in addition to an unexpected error
Reported by: | roed | Owned by: | mvngu |
---|---|---|---|
Priority: | major | Milestone: | sage-5.9 |
Component: | doctest framework | Keywords: | |
Cc: | Merged in: | sage-5.9.beta4 | |
Authors: | David Roe | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14289, #14290, #14331, #13278, #14370 | Stopgaps: |
Description
#12415 introduces the ability to drop into a Python debugger when an unexpected error is encountered. I was attempting to have a similar behavior happen when an incorrect result was obtained so that it's easier to figure out what has gone wrong in the doctest. But problems with interrupt handling were delaying the completion of #12415 (already a patchbomb), so I've stripped out that functionality and put it here.
Attachments (2)
Change History (14)
comment:1 Changed 8 years ago by
- Dependencies changed from #12415 to #14289
comment:2 Changed 8 years ago by
- Dependencies changed from #14289 to #14289, #14290
Changed 8 years ago by
comment:3 Changed 8 years ago by
- Status changed from new to needs_review
comment:4 Changed 8 years ago by
- Component changed from doctest to doctest framework
comment:5 Changed 8 years ago by
- Dependencies changed from #14289, #14290 to #14289, #14290, #14331, #13278, #14370
- Status changed from needs_review to needs_work
comment:6 Changed 8 years ago by
- Reviewers set to Jeroen Demeyer
- Status changed from needs_work to needs_review
comment:7 Changed 8 years ago by
- Status changed from needs_review to positive_review
Review patch looks good to me.
comment:8 Changed 8 years ago by
- Work issues keyboard interrupt, doctesting after exiting the debugger not working correctly deleted
comment:9 Changed 8 years ago by
- Status changed from positive_review to needs_work
Doctest failure in sage/tests/cmdline.py
Changed 8 years ago by
comment:10 Changed 8 years ago by
- Status changed from needs_work to needs_review
comment:12 Changed 8 years ago by
- Merged in set to sage-5.9.beta4
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Alright, this works for me on OS X. Needs review.