Opened 10 years ago

Closed 10 years ago

#13610 closed enhancement (fixed)

Make sage -t --debug trigger on an incorrect doctest in addition to an unexpected error

Reported by: David Roe Owned by: Minh Van Nguyen
Priority: major Milestone: sage-5.9
Component: doctest framework Keywords:
Cc: Merged in: sage-5.9.beta4
Authors: David Roe Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14289, #14290, #14331, #13278, #14370 Stopgaps:

Status badges

Description

#12415 introduces the ability to drop into a Python debugger when an unexpected error is encountered. I was attempting to have a similar behavior happen when an incorrect result was obtained so that it's easier to figure out what has gone wrong in the doctest. But problems with interrupt handling were delaying the completion of #12415 (already a patchbomb), so I've stripped out that functionality and put it here.

Attachments (2)

13610.patch (5.7 KB) - added by David Roe 10 years ago.
13610_review.patch (4.4 KB) - added by Jeroen Demeyer 10 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 10 years ago by David Roe

Dependencies: #12415#14289

comment:2 Changed 10 years ago by David Roe

Dependencies: #14289#14289, #14290

Changed 10 years ago by David Roe

Attachment: 13610.patch added

comment:3 Changed 10 years ago by David Roe

Status: newneeds_review

Alright, this works for me on OS X. Needs review.

comment:4 Changed 10 years ago by David Roe

Component: doctestdoctest framework

comment:5 Changed 10 years ago by Jeroen Demeyer

Dependencies: #14289, #14290#14289, #14290, #14331, #13278, #14370
Status: needs_reviewneeds_work

comment:6 Changed 10 years ago by Jeroen Demeyer

Reviewers: Jeroen Demeyer
Status: needs_workneeds_review

comment:7 Changed 10 years ago by David Roe

Status: needs_reviewpositive_review

Review patch looks good to me.

comment:8 Changed 10 years ago by Jeroen Demeyer

Work issues: keyboard interrupt, doctesting after exiting the debugger not working correctly

comment:9 Changed 10 years ago by Jeroen Demeyer

Status: positive_reviewneeds_work

Doctest failure in sage/tests/cmdline.py

Changed 10 years ago by Jeroen Demeyer

Attachment: 13610_review.patch added

comment:10 Changed 10 years ago by Jeroen Demeyer

Status: needs_workneeds_review

comment:11 Changed 10 years ago by David Roe

Status: needs_reviewpositive_review

Looks good.

comment:12 Changed 10 years ago by Jeroen Demeyer

Merged in: sage-5.9.beta4
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.