Opened 10 years ago
Closed 10 years ago
#1361 closed defect (fixed)
[with patch, with positive review] reimplement graph generation
Reported by: | rlm | Owned by: | rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-2.8.15 |
Component: | combinatorics | Keywords: | graphs |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Changes:
- Redefine order to be number of edges.
- Start with empty graph.
- Augment by adding 1 edge.
- Cython-ize.
Attachments (1)
Change History (7)
comment:1 Changed 10 years ago by
- Owner changed from mhansen to rlm
- Status changed from new to assigned
comment:2 Changed 10 years ago by
- Milestone changed from sage-2.10 to sage-2.8.15
Changed 10 years ago by
comment:3 Changed 10 years ago by
comment:4 Changed 10 years ago by
- Summary changed from reimplement graph generation to [with patch] reimplement graph generation
comment:5 Changed 10 years ago by
- Summary changed from [with patch] reimplement graph generation to [with patch, with positive review] reimplement graph generation
Looks good to me. (Code looks reasonable, doctests pass in sage/graphs/.)
comment:6 Changed 10 years ago by
- Resolution set to fixed
- Status changed from assigned to closed
Merged in 2.8.15.alpha2.
Note: See
TracTickets for help on using
tickets.
Implementing in Cython should have little effect, since what is in Python is certainly not the bottleneck.