Opened 10 years ago

Closed 9 years ago

#13606 closed enhancement (fixed)

Adding anticommutator feature

Reported by: Oscar Castillo-Felisola Owned by: jason, was
Priority: minor Milestone: sage-5.10
Component: linear algebra Keywords:
Cc: Merged in: sage-5.10.beta0
Authors: Oscar Castillo-Felisola, Travis Scrimshaw Reviewers: Kannappan Sampath
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

When working with matrices, the commutator is a useful feature. However, the anticommutator is handy when one is working with representations of, say, Clifford algebras.


Apply: trac_13606-anticommutator-ts.patch

Attachments (1)

trac_13606-anticommutator-ts.patch (1.3 KB) - added by Travis Scrimshaw 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by Oscar Castillo-Felisola

Status: newneeds_review

comment:2 Changed 10 years ago by Kannappan Sampath

I'd like to review this ticket. Here are my comments:

  1. Please fix the docstring: we need "anticommutator" and NOT "commutator". I'd be glad if you rewrote the docstring along the lines of:
"""
Return the anticommutator of ``self`` and ``other``. 

The anticommutator of two square matrices `A` and `B` of same 
dimension is defined to be `AB + BA`. 

EXAMPLES::


"""
  1. Perhaps, we could add atleast one more example, like the trace of anticommutator. But, this is just my feeling.

Other than these, the patch looks great! :)

Version 0, edited 10 years ago by Kannappan Sampath (next)

comment:3 Changed 10 years ago by Kannappan Sampath

Authors: Oscar Castillo-Felisola
Reviewers: Kannappan Sampath
Status: needs_reviewneeds_work

Changed 9 years ago by Travis Scrimshaw

comment:4 Changed 9 years ago by Travis Scrimshaw

Authors: Oscar Castillo-FelisolaOscar Castillo-Felisola, Travis Scrimshaw
Description: modified (diff)
Status: needs_workneeds_review

I've uploaded a patch which fixes up the documentation.

For patchbot:

Apply: trac_13606-anticommutator-ts.patch

comment:5 Changed 9 years ago by Kannappan Sampath

Status: needs_reviewpositive_review

comment:6 Changed 9 years ago by Travis Scrimshaw

Thanks for the review.

comment:7 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.9sage-5.10

comment:8 Changed 9 years ago by Jeroen Demeyer

Description: modified (diff)

comment:9 Changed 9 years ago by Jeroen Demeyer

Merged in: sage-5.10.beta0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.