Opened 9 years ago

Closed 8 years ago

#13606 closed enhancement (fixed)

Adding anticommutator feature

Reported by: dox Owned by: jason, was
Priority: minor Milestone: sage-5.10
Component: linear algebra Keywords:
Cc: Merged in: sage-5.10.beta0
Authors: Oscar Castillo-Felisola, Travis Scrimshaw Reviewers: Kannappan Sampath
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

When working with matrices, the commutator is a useful feature. However, the anticommutator is handy when one is working with representations of, say, Clifford algebras.

Apply: trac_13606-anticommutator-ts.patch

Attachments (1)

trac_13606-anticommutator-ts.patch (1.3 KB) - added by tscrim 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by dox

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by knsam

I'd like to review this ticket. Here are my comments:

  1. Please fix the docstring: we need "anticommutator" and NOT "commutator". I'd be glad if you rewrote the docstring along the lines of:
Return the anticommutator of ``self`` and ``other``. 

The anticommutator of two square matrices `A` and `B` of same 
dimension is defined to be `AB + BA`. 


  1. Perhaps, we could add atleast one more example, like the trace of anticommutator. May be, also, how the product AB is related to commutator and anticommutator of A and B. But, this is just my feeling.

Other than these, the patch looks great! :)

Last edited 8 years ago by knsam (previous) (diff)

comment:3 Changed 8 years ago by knsam

  • Authors set to Oscar Castillo-Felisola
  • Reviewers set to Kannappan Sampath
  • Status changed from needs_review to needs_work

Changed 8 years ago by tscrim

comment:4 Changed 8 years ago by tscrim

  • Authors changed from Oscar Castillo-Felisola to Oscar Castillo-Felisola, Travis Scrimshaw
  • Description modified (diff)
  • Status changed from needs_work to needs_review

I've uploaded a patch which fixes up the documentation.

For patchbot:

Apply: trac_13606-anticommutator-ts.patch

comment:5 Changed 8 years ago by knsam

  • Status changed from needs_review to positive_review

comment:6 Changed 8 years ago by tscrim

Thanks for the review.

comment:7 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.9 to sage-5.10

comment:8 Changed 8 years ago by jdemeyer

  • Description modified (diff)

comment:9 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.10.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.