Changes between Initial Version and Version 1 of Ticket #13605, comment 35


Ignore:
Timestamp:
02/16/13 04:55:14 (8 years ago)
Author:
andrew.mathas
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13605, comment 35

    initial v1  
    11Hi Travis,
    22
    3 Not sure that I will be able to upload to he queue from the airport, but I've found two problems that I can't see an easy fix for. Quite possibly you have already fixed them, but please try:
     3Not sure that I will be able to upload to the queue from the airport, but I've found two problems that I can't see an easy fix for. Quite possibly you have already fixed them, but please try:
    44
    55{{{
    66TestSuite( OrderedPartitions(5,3) ).run(
    7 TestSuite(Partitions(5, min_part=2)).run()
     7TestSuite( Partitions(5, min_part=2) ).run()
    88}}}
    99
    1010Both of them give errors for me.
    1111
     12Apart form this I have finished my review. I'll have to have a look over the changes that you have made and someone will have to review my review as it has gotten quite large -- as I discussed with you and Nicolas, I have replaced your partition and tableau options with a general global_options class and I also fixed up tex_from_array so that it now copes with arbitrary skew composition tuples.
    1213
    13 Apart form this I have finished my review. I'll have to have a look over the changes that you have made and someone will have to reivew my review as it has gotten quite large -- as I discussed with you and Nicolas, I have replaced your partition and tableau options with a general global_options class and I also fixed up tex_from_array so that it now copes with arbitrary skew composition tuples.
    14 
    15 Will upload to trac and the queue as soon as I am able, but this probably won't be ntil Monday Sydney time.
     14Will upload to trac and the queue as soon as I am able, but this probably won't be until Monday Sydney time due to the connection here -- and I first need to rebase over your changes.
    1615
    1716Cheers.,
    1817Andrew
    19 Cheers,
    20 Andrew