Opened 10 years ago

Closed 10 years ago

#13603 closed defect (worksforme)

.DS_Store garbage in rpy2-2.0.8.p0

Reported by: Paul-Olivier Dehaye Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords: DS_Store, rpy2
Cc: Merged in:
Authors: Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

src/.DS_Store corrupts OS X 10.8 installation

Change History (8)

comment:2 Changed 10 years ago by Paul-Olivier Dehaye

Keywords: DS_Store rpy2 added
Status: newneeds_review

comment:3 Changed 10 years ago by Karl-Dieter Crisman

Authors: Paul-Olivier Dehaye

comment:4 Changed 10 years ago by Karl-Dieter Crisman

Reviewers: Karl-Dieter Crisman

Seems ok. Works on OS X and sage.math.

I'm wondering whether

 == Special Update/Build Instructions ==
  * setup.py change takes care of a few parsing issues and location issues
  * does this need to be reported upstream, or is it Sage-specific?
+ * #13603: Removed src/.DS_Store

should have just instructions to remove that if present, like the other bullet points in similar lists.

comment:5 Changed 10 years ago by Karl-Dieter Crisman

In retrospect, actually this message should be in the SPKG.txt log, not under instructions, unless it was in upstream, which I can hardly believe (we or I must have introduced it).

comment:6 Changed 10 years ago by Karl-Dieter Crisman

Status: needs_reviewneeds_work

comment:7 Changed 10 years ago by Karl-Dieter Crisman

Authors: Paul-Olivier Dehaye
Milestone: sage-5.7sage-duplicate/invalid/wontfix
Status: needs_workpositive_review

Note that now we have r-2.14.0.p6.spkg, and it seems to be gone.

$ ls -aR | grep DS_Store

Also, apparently 2.7.1 R introduced

    o   R CMD build tries harder to clean up the inst/doc directory
        from the remnants of earlier builds.

        It also removes any directories with extension .Rcheck, and
        files .DS_Store and ._* (created by tar on Mac OS X under some
        circumstances: it now sets environment variables to ask for
        such files not to be created by that tar.)

So I think we can close this. Sorry your spkg didn't get in, Paul-Olivier! Though I guess I'm glad this was taken care of upstream.

Last edited 10 years ago by Karl-Dieter Crisman (previous) (diff)

comment:8 Changed 10 years ago by Jeroen Demeyer

Resolution: worksforme
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.