Opened 10 years ago
Closed 10 years ago
#13590 closed defect (fixed)
Fix random simplicial complexes
Reported by: | jhpalmieri | Owned by: | John Palmieri |
---|---|---|---|
Priority: | critical | Milestone: | sage-5.5 |
Component: | algebraic topology | Keywords: | simplicial complex |
Cc: | Merged in: | sage-5.5.beta0 | |
Authors: | John Palmieri | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #13244 | Stopgaps: |
Description (last modified by )
Random simplicial complexes don't have the right number of vertices. From the doctests:
sage: simplicial_complexes.RandomComplex(6, 2) Simplicial complex with vertex set (0, 1, 2, 3, 4, 5, 6) and 15 facets sage: simplicial_complexes.RandomComplex(6,12) Simplicial complex with vertex set (0, 1, 2, 3, 4, 5, 6, 7) and facets {(0, 1, 2, 3, 4, 5, 6, 7)}
In both cases, these should have 6 vertices, but they have 7 and 8 instead. Thus this method gives mathematically incorrect answers. The attached patch fixes the problems.
Attachments (1)
Change History (7)
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
comment:2 Changed 10 years ago by
- Description modified (diff)
comment:3 Changed 10 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
comment:4 Changed 10 years ago by
- Dependencies set to #13244
- Status changed from positive_review to needs_work
This conflicts with #13244 and should be rebased.
comment:5 Changed 10 years ago by
- Status changed from needs_work to positive_review
Okay, rebased now.
Changed 10 years ago by
comment:6 Changed 10 years ago by
- Merged in set to sage-5.5.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Looks good to me.