Opened 9 years ago

Closed 9 years ago

#13578 closed enhancement (fixed)

Generator for Ringed-Tree graphs

Reported by: dcoudert Owned by: jason, ncohen, rlm
Priority: minor Milestone: sage-5.5
Component: graph theory Keywords:
Cc: ncohen Merged in: sage-5.5.beta1
Authors: David Coudert Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #13306 Stopgaps:

Status badges

Description (last modified by ncohen)

A ringed tree of level k is a fully binary tree with k levels (counting the root as a level) in which all vertices at the same level are connected by a ring. Such graphs have been used for instance in http://arxiv.org/abs/1201.1717.

Apply:

Attachments (2)

trac_13578-ringedtree.patch (4.1 KB) - added by dcoudert 9 years ago.
trac_13578-rev.patch (6.8 KB) - added by ncohen 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by dcoudert

comment:1 follow-up: Changed 9 years ago by ncohen

  • Description modified (diff)
  • Status changed from new to needs_review

Hellooooooooo David !!

Here is a ... reviewer's patch :-D

You created a file containing a method "RingedTree?", but you called it "families.py"... If we move all the stuff from graph_generators to families.py and other files, would you see a problem with putting Robert Miller's copyright from graph_generators.py at the head of families.py (and we will do the same at the head of the new files we will create) ? Otherwise it would be a bit like stealing the copyright just by moving the code around ^^;

If you agree with the patch you can set the ticket to "positive review". And we will handle all that stuff when we will move the code around !

Nathann

Changed 9 years ago by ncohen

comment:2 in reply to: ↑ 1 ; follow-up: Changed 9 years ago by dcoudert

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Here is a ... reviewer's patch :-D

You have fully rewritten the function in a much smarter way. Thanks! I was not aware of the circle embedding function. Nice.

You created a file containing a method "RingedTree?", but you called it "families.py"... If we move all the stuff from graph_generators to families.py and other files, would you see a problem with putting Robert Miller's copyright from graph_generators.py at the head of families.py (and we will do the same at the head of the new files we will create) ? Otherwise it would be a bit like stealing the copyright just by moving the code around ^^;

You are perfectly right. We could may be already put his name and remove mine.

If you agree with the patch you can set the ticket to "positive review". And we will handle all that stuff when we will move the code around !

I agree with the patch. Many thanks.

PS: I have put your name as reviewer, but may be it should be author?

comment:3 in reply to: ↑ 2 Changed 9 years ago by ncohen

Yooooooooooooooooooooooo !!!

You are perfectly right. We could may be already put his name and remove mine.

Well.. This one is reviewed already, so let's settle this with a big nasty patch that will totally destroy the graph_generators file :-D

I agree with the patch.

Yeah !

PS: I have put your name as reviewer, but may be it should be author?

It's perfect as it is :-)

By the way, I'm living in a shared flat right now, for something like a month or so. This way I can see what life is like in Paris, including the loooooong commuting toward Orsay. Well, I'll be looking for a new flat in a couple of weeks and the rents here are really expensive (750~800 for a "studio"), but the city is real nice.... ;-)

Nathann

comment:4 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.5.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.