Opened 10 years ago

Last modified 5 years ago

#13568 needs_work enhancement

Quaternion Orders over Number Fields

Reported by: aly.deines Owned by: AlexGhitza
Priority: major Milestone: sage-6.4
Component: algebra Keywords: quaternion, order
Cc: schisholm, daniels Merged in:
Authors: Aly Deines Reviewers: Gonzalo Tornaría
Report Upstream: N/A Work issues:
Branch: u/aurel/13568-review (Commits, GitHub, GitLab) Commit: afba2742b6e1696172343fbe439bb2e2af5059e7
Dependencies: Stopgaps:

Status badges

Description

Generalizes the code for quaternion orders of quaternion algebras over QQ to allow for quaternion orders of quaternion algebras over number fields.

Attachments (1)

Trac13569_quaternion_orders.patch​ (35.7 KB) - added by aly.deines 10 years ago.

Download all attachments as: .zip

Change History (25)

Changed 10 years ago by aly.deines

comment:1 Changed 10 years ago by aly.deines

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by aly.deines

  • Status changed from needs_review to needs_work

comment:3 Changed 9 years ago by daniels

  • Cc daniels added

comment:4 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:5 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:7 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:8 Changed 8 years ago by tornaria

  • Branch set to u/tornaria/ticket/13568
  • Commit set to 733e6515382dd92a106efb1316b991615f056c30

Rebased the patch to sage-6.4.beta1 and moved to git

comment:9 Changed 8 years ago by aly.deines

  • Status changed from needs_work to needs_review

comment:10 Changed 8 years ago by git

  • Commit changed from 733e6515382dd92a106efb1316b991615f056c30 to 9858d7eb13f47187ac2b2d5f3b0139d0f96fe1d8

Branch pushed to git repo; I updated commit sha1. New commits:

​e495dc1Trac #13569: fix whitespace
​70614ddTrac #13569: fix usage of raise
​0a3ca50Trac #13569: remove unnecessary import
​4fbac85Trac #13569: style changes
​f824306Trac #13569: Revert basis of quaternion algebras and orders to be tuples
​9858d7eTrac #13569: document and test new argument ideal_list

comment:11 Changed 8 years ago by tornaria

I've pushed a bunch of reviewer commits, the log explains them (esp f824306).

There's still a bug, namely when the base field is QQ and a pseudo-basis is given, the current code will just ignore the ideals.

comment:12 Changed 8 years ago by aly.deines

  • Status changed from needs_review to needs_work

Okay. I'll get on that.

comment:13 Changed 8 years ago by git

  • Commit changed from 9858d7eb13f47187ac2b2d5f3b0139d0f96fe1d8 to 1e8d1e2ddf533c55874bbbaa5af30bd810bc21b8

Branch pushed to git repo; I updated commit sha1. New commits:

​1e8d1e2Trac #13569: fix when base_field=QQ and pseudo-basis is given

comment:14 Changed 8 years ago by tornaria

  • Reviewers set to tornaria
  • Status changed from needs_work to needs_review

I'm happy with this now. Since I made a lot of changes I'm leaving it as needs_review.

comment:15 Changed 8 years ago by aly.deines

  • Branch changed from u/tornaria/ticket/13568 to u/aly.deines/ticket/13568

comment:16 Changed 8 years ago by git

  • Commit changed from 1e8d1e2ddf533c55874bbbaa5af30bd810bc21b8 to bd9fe8546fdbb21332d9204ccdd31b33393f353c

Branch pushed to git repo; I updated commit sha1. New commits:

​bd9fe85Some cleanup.

comment:17 Changed 8 years ago by git

  • Commit changed from bd9fe8546fdbb21332d9204ccdd31b33393f353c to 9f9af0ded499b182860520ae8bd533d0009fc2fa

Branch pushed to git repo; I updated commit sha1. New commits:

​9f9af0dFixed the Brandt.py documentation.

comment:18 Changed 8 years ago by git

  • Commit changed from 9f9af0ded499b182860520ae8bd533d0009fc2fa to 8ed696d81fd73edf665f64192656d8e8b7f75b31

Branch pushed to git repo; I updated commit sha1. New commits:

​130d486Removed extra generated files.
​8ed696dDelated an extra git-trac-command folder.

comment:19 Changed 8 years ago by mmasdeu

  • Branch changed from u/aly.deines/ticket/13568 to u/mmasdeu/13568-review
  • Commit changed from 8ed696d81fd73edf665f64192656d8e8b7f75b31 to 73909fda05d5fe4dc5c8d39c9cb4e334d7e0aa24
  • Status changed from needs_review to needs_work

comment:20 Changed 8 years ago by mmasdeu

I started reviewing it, and made some changes. Some are to make it more pythonic, some are for clarity.

I've set it to needs_work because the patch fails when using quaternion algebras not defined over number fields: 

sage: A.<i,j,k> = QuaternionAlgebra(ZZ['x'].fraction_field(),-1,-1)
sage: A.quaternion_order([1,i,j,k])                                
---------------------------------------------------------------------------
UnboundLocalError                         Traceback (most recent call last)
...
UnboundLocalError: local variable 'M1' referenced before assignment

comment:21 Changed 7 years ago by jdemeyer

Just a remark: this functionality is in PARI now, so you could just try to wrap PARI.

comment:22 Changed 5 years ago by aurel

  • Branch changed from u/mmasdeu/13568-review to u/aurel/13568-review

comment:23 Changed 5 years ago by aurel

  • Commit changed from 73909fda05d5fe4dc5c8d39c9cb4e334d7e0aa24 to afba2742b6e1696172343fbe439bb2e2af5059e7

With Marc Masdeu, we checked that this is still compiling after rebasing on develop. We intend to have a look at this ticket.

Last 10 new commits:

​c4276e6Fixed a merging error.
​055e633Changed to tuples.
​18c5420More fixes.
​5b1046eSome cleanup.
​9c67df8Fixed the Brandt.py documentation.
​188229bRemoved extra generated files.
​f668c09Delated an extra git-trac-command folder.
​b7a7864Trac 13568: Reviewer's patch.
​aa554bcFixed transpose mistake.
​afba274Some minor changes, initialized __basis and __pseudobasis to None.

comment:24 Changed 5 years ago by jdemeyer

  • Dependencies #13509 - Pari nfhnf deleted
  • Reviewers changed from tornaria to Gonzalo Tornaría
Note: See TracTickets for help on using tickets.