#13547 closed enhancement (fixed)
Update Cremona's table of elliptic curves to 300000
Reported by: | cremona | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-5.7 |
Component: | packages: optional | Keywords: | elliptic curves |
Cc: | robertwb, ohanar | Merged in: | |
Authors: | John Cremona | Reviewers: | Jonathan Bober |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
On 2012-09-27 John Cremona published an update of his database covering conductors up to 280000, and on 2012-10-13 and 2012-10-22 two other updates covered conductors to 300000. The optional spkg database_cremona_ellcurve has been updated accordingly.
Updated spkg: http://homepages.warwick.ac.uk/staff/J.E.Cremona/ftp/database_cremona_ellcurve-20121022.spkg
Change History (13)
comment:1 Changed 9 years ago by
- Description modified (diff)
comment:2 Changed 9 years ago by
- Description modified (diff)
- Summary changed from Update Cremona's table of elliptic curves to 280000 to Update Cremona's table of elliptic curves to 290000
comment:3 Changed 9 years ago by
- Description modified (diff)
comment:4 Changed 9 years ago by
There's one doctest failure after the new db is installed, in heegner.py where a curve is used which has conductor 100001. This was also a problem / feature with the previous version of the large database. I intended to make a patch with a different example, but that it not easy since the example chosen was done so to illustrate a particular feature. One could easily change that doctest into one which passes with & without the optional db installed, but it would be less easy to do so in a way which illustrates the same point.
comment:5 Changed 9 years ago by
- Cc robertwb ohanar added
- Status changed from new to needs_review
comment:6 Changed 8 years ago by
- Description modified (diff)
- Summary changed from Update Cremona's table of elliptic curves to 290000 to Update Cremona's table of elliptic curves to 300000
comment:7 follow-up: ↓ 8 Changed 8 years ago by
- Status changed from needs_review to positive_review
I can't see any reason that this shouldn't get a positive review, unless the reviewer is supposed to recompute all the data to make sure that Cremona isn't pulling a fast one on us. (And I was annoyed recently when I realized that the current optional spkg is incomplete, which is a good reason for giving this a positive review.)
comment:8 in reply to: ↑ 7 Changed 8 years ago by
Replying to bober:
I can't see any reason that this shouldn't get a positive review, unless the reviewer is supposed to recompute all the data to make sure that Cremona isn't pulling a fast one on us.
That's a great idea! And of course you are not allowed to use any of eclib to do so. Then we could be really confident in the data.
(And I was annoyed recently when I realized that the current optional spkg is incomplete, which is a good reason for giving this a positive review.)
Thanks. I checked my release notes (at http://homepages.warwick.ac.uk/staff/J.E.Cremona/ftp/data/release_notes.txt) and there have been no corrections since October which affect the spkg.
comment:9 Changed 8 years ago by
Please fill in the Author/Reviewer? fields.
comment:10 Changed 8 years ago by
- Keywords elliptic curves added
- Reviewers set to Jonathan Bober
comment:11 Changed 8 years ago by
spkg updated on the servers!
comment:12 follow-up: ↓ 13 Changed 8 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
comment:13 in reply to: ↑ 12 Changed 8 years ago by
Replying to jdemeyer: Thank you! I am not planning any further expansion of the database in the near future.
I'll mark this as Needs Review when I have finished my own testing.