Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#13547 closed enhancement (fixed)

Update Cremona's table of elliptic curves to 300000

Reported by: cremona Owned by: tbd
Priority: major Milestone: sage-5.7
Component: packages: optional Keywords: elliptic curves
Cc: robertwb, ohanar Merged in:
Authors: John Cremona Reviewers: Jonathan Bober
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description (last modified by cremona)

On 2012-09-27 John Cremona published an update of his database covering conductors up to 280000, and on 2012-10-13 and 2012-10-22 two other updates covered conductors to 300000. The optional spkg database_cremona_ellcurve has been updated accordingly.

Updated spkg: http://homepages.warwick.ac.uk/staff/J.E.Cremona/ftp/database_cremona_ellcurve-20121022.spkg

Change History (13)

comment:1 Changed 10 years ago by cremona

Description: modified (diff)

I'll mark this as Needs Review when I have finished my own testing.

comment:2 Changed 10 years ago by cremona

Description: modified (diff)
Summary: Update Cremona's table of elliptic curves to 280000Update Cremona's table of elliptic curves to 290000

comment:3 Changed 10 years ago by cremona

Description: modified (diff)

comment:4 Changed 10 years ago by cremona

There's one doctest failure after the new db is installed, in heegner.py where a curve is used which has conductor 100001. This was also a problem / feature with the previous version of the large database. I intended to make a patch with a different example, but that it not easy since the example chosen was done so to illustrate a particular feature. One could easily change that doctest into one which passes with & without the optional db installed, but it would be less easy to do so in a way which illustrates the same point.

Last edited 10 years ago by cremona (previous) (diff)

comment:5 Changed 10 years ago by cremona

Cc: robertwb ohanar added
Status: newneeds_review

comment:6 Changed 10 years ago by cremona

Description: modified (diff)
Summary: Update Cremona's table of elliptic curves to 290000Update Cremona's table of elliptic curves to 300000

comment:7 Changed 10 years ago by bober

Status: needs_reviewpositive_review

I can't see any reason that this shouldn't get a positive review, unless the reviewer is supposed to recompute all the data to make sure that Cremona isn't pulling a fast one on us. (And I was annoyed recently when I realized that the current optional spkg is incomplete, which is a good reason for giving this a positive review.)

comment:8 in reply to:  7 Changed 10 years ago by cremona

Replying to bober:

I can't see any reason that this shouldn't get a positive review, unless the reviewer is supposed to recompute all the data to make sure that Cremona isn't pulling a fast one on us.

That's a great idea! And of course you are not allowed to use any of eclib to do so. Then we could be really confident in the data.

(And I was annoyed recently when I realized that the current optional spkg is incomplete, which is a good reason for giving this a positive review.)

Thanks. I checked my release notes (at http://homepages.warwick.ac.uk/staff/J.E.Cremona/ftp/data/release_notes.txt) and there have been no corrections since October which affect the spkg.

comment:9 Changed 10 years ago by jdemeyer

Please fill in the Author/Reviewer? fields.

comment:10 Changed 10 years ago by cremona

Authors: John Cremona
Keywords: elliptic curves added
Reviewers: Jonathan Bober

comment:11 Changed 10 years ago by schilly

spkg updated on the servers!

comment:12 Changed 10 years ago by jdemeyer

Resolution: fixed
Status: positive_reviewclosed

comment:13 in reply to:  12 Changed 10 years ago by cremona

Replying to jdemeyer: Thank you! I am not planning any further expansion of the database in the near future.

Note: See TracTickets for help on using tickets.