Opened 8 years ago
Closed 8 years ago
#13537 closed defect (fixed)
Stopgap for 13439
Reported by: | saraedum | Owned by: | tbd |
---|---|---|---|
Priority: | blocker | Milestone: | sage-5.4 |
Component: | padics | Keywords: | |
Cc: | Merged in: | sage-5.4.rc1 | |
Authors: | Julian Rueth | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
See #13439.
Attachments (1)
Change History (9)
Changed 8 years ago by
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
- Status changed from new to needs_review
comment:3 Changed 8 years ago by
comment:4 Changed 8 years ago by
- Component changed from PLEASE CHANGE to padics
comment:5 follow-up: ↓ 7 Changed 8 years ago by
Does this really have to be a sage-5.4 blocker?
comment:6 Changed 8 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
Looks good to me.
comment:7 in reply to: ↑ 5 Changed 8 years ago by
Replying to jdemeyer:
Does this really have to be a sage-5.4 blocker?
I followed the developer's guide: "Stopgap tickets should be marked as blockers." Should I have changed the version?
comment:8 Changed 8 years ago by
- Merged in set to sage-5.4.rc1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Instead of adding a second stopgap warning to the
_xgcd
method ofPolynomial_padic_field_dense
, I removed it entirely. It is a protected method, with no doctest which is not called anywhere in sage: