Opened 10 years ago
Closed 10 years ago
#13537 closed defect (fixed)
Stopgap for 13439
Reported by: | Julian Rüth | Owned by: | tbd |
---|---|---|---|
Priority: | blocker | Milestone: | sage-5.4 |
Component: | padics | Keywords: | |
Cc: | Merged in: | sage-5.4.rc1 | |
Authors: | Julian Rueth | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
See #13439.
Attachments (1)
Change History (9)
Changed 10 years ago by
Attachment: | trac_13537.patch added |
---|
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
Status: | new → needs_review |
---|
comment:3 Changed 10 years ago by
Authors: | → Julian Rueth |
---|
comment:4 Changed 10 years ago by
Component: | PLEASE CHANGE → padics |
---|
comment:6 Changed 10 years ago by
Reviewers: | → Volker Braun |
---|---|
Status: | needs_review → positive_review |
Looks good to me.
comment:7 Changed 10 years ago by
Replying to jdemeyer:
Does this really have to be a sage-5.4 blocker?
I followed the developer's guide: "Stopgap tickets should be marked as blockers." Should I have changed the version?
comment:8 Changed 10 years ago by
Merged in: | → sage-5.4.rc1 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Instead of adding a second stopgap warning to the
_xgcd
method ofPolynomial_padic_field_dense
, I removed it entirely. It is a protected method, with no doctest which is not called anywhere in sage: