Opened 7 years ago

Closed 7 years ago

#13537 closed defect (fixed)

Stopgap for 13439

Reported by: saraedum Owned by: tbd
Priority: blocker Milestone: sage-5.4
Component: padics Keywords:
Cc: Merged in: sage-5.4.rc1
Authors: Julian Rueth Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

See #13439.

Attachments (1)

trac_13537.patch (1.7 KB) - added by saraedum 7 years ago.

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by saraedum

comment:1 Changed 7 years ago by saraedum

Instead of adding a second stopgap warning to the _xgcd method of Polynomial_padic_field_dense, I removed it entirely. It is a protected method, with no doctest which is not called anywhere in sage:

sage: search_src("Polynomial_padic_field_dense")
rings/polynomial/polynomial_element_generic.py:777:class Polynomial_padic_field_dense(Polynomial_padic_generic_dense, Polynomial_generic_dense_field):
rings/polynomial/polynomial_element_generic.py:796:class Polynomial_padic_field_lazy_dense(Polynomial_padic_field_dense):

sage: search_src("Polynomial_padic_field_lazy_dense")
rings/polynomial/polynomial_element_generic.py:787:class Polynomial_padic_field_lazy_dense(Polynomial_padic_field_dense):

comment:2 Changed 7 years ago by saraedum

  • Status changed from new to needs_review

comment:3 Changed 7 years ago by saraedum

  • Authors set to Julian Rueth

comment:4 Changed 7 years ago by jdemeyer

  • Component changed from PLEASE CHANGE to padics

comment:5 follow-up: Changed 7 years ago by jdemeyer

Does this really have to be a sage-5.4 blocker?

comment:6 Changed 7 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Looks good to me.

comment:7 in reply to: ↑ 5 Changed 7 years ago by saraedum

Replying to jdemeyer:

Does this really have to be a sage-5.4 blocker?

I followed the developer's guide: "Stopgap tickets should be marked as blockers." Should I have changed the version?

comment:8 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.4.rc1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.