Changes between Version 14 and Version 26 of Ticket #13516


Ignore:
Timestamp:
11/22/12 06:19:29 (9 years ago)
Author:
ppurka
Comment:

Thanks a lot for addressing my concerns. I have made some changes to your patch.

  1. Fixed trailing whitespaces.
  2. Made sure prime_powers(-1, positive integer) works.
  3. Fixed TypeError.

The changes can be seen in 13516_reviewer.patch. All these changes have been merged with your patch and the new patch is now 13516_primepowers.2.patch.

Aside from the above corrections, the changes introduced by your patch has positive review from my side. If you think my changes are ok, feel free to change the ticket to positive review.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13516

    • Property Reviewers changed from to Punarbasu Purkayastha
  • Ticket #13516 – Description

    v14 v26  
    3131Yeah, this seems problematic.  The code in question is ''old'', too, so perhaps there is a more efficient way to do it in the meantime...
    3232
    33 '''Apply'''
    34 
    35 1. [http://trac.sagemath.org/sage_trac/raw-attachment/ticket/13516/13516_primepowers.patch patch]
     33'''Apply''' to `devel/sage`: [attachment:13516_reviewer.2.patch].