Opened 8 years ago
Closed 8 years ago
#13509 closed enhancement (fixed)
Pari nfhnf - hnf over number fields
Reported by: | aly.deines | Owned by: | jason, was |
---|---|---|---|
Priority: | major | Milestone: | sage-5.4 |
Component: | linear algebra | Keywords: | nfhnf, pseudo-matrix |
Cc: | schisholm | Merged in: | sage-5.4.rc0 |
Authors: | Aly Deines | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
I've added the pari nfhnf to the sage available pari library.
Attachments (1)
Change History (8)
comment:1 Changed 8 years ago by
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
- Reviewers set to Jeroen Demeyer
- Status changed from needs_review to needs_work
Changed 8 years ago by
comment:4 Changed 8 years ago by
Done and done. I also added the definition of pseudo-basis and an example where the class number is 2.
comment:5 Changed 8 years ago by
- Status changed from needs_work to needs_review
comment:6 Changed 8 years ago by
- Status changed from needs_review to positive_review
Looks good to me.
comment:7 Changed 8 years ago by
- Merged in set to sage-5.4.rc0
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Could you insert the
nfhnf()
declaration in alphabetical order and shorten the very long lines in thenfhnf()
docstring?