Opened 9 years ago

Closed 8 years ago

#13505 closed enhancement (fixed)

Implement Bases of NCSF and QSym

Reported by: chrisjamesberg Owned by: chrisjamesberg
Priority: major Milestone: sage-5.12
Component: combinatorics Keywords: NCSF QSym
Cc: saliola, combinat Merged in: sage-5.12.beta5
Authors: Chris Berg, Jeffrey Ferreira Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14101 Stopgaps:

Status badges

Description (last modified by jferreira)

This patch is an attempt to implement new bases of NCSF and QSym which currently exist on the combinat server. This includes the Monomial basis and Fundamental basis of Tevlin, the dual of the quasisymmetric Schur function introduced by Haglund, Luoto, Mason and van-Willigenburg, the Immaculate basis, introduced by Berg, Bergeron, Saliola, Serrano and Zabrocki. In QSym, it will implement all of the dual bases of NCSF.

Currently the attached patch implements only the Quasisymmetric Schur functions of Haglund, Luoto, Mason, and van-Willigenburg, plus some combinatorics of Composition Tableaux


Apply:

Attachments (6)

trac_13505_quasi_schur.patch (23.0 KB) - added by jferreira 8 years ago.
Applies cleanly to sage-5.10.rc1
trac_13505_quasi_schur.2.patch (23.0 KB) - added by jferreira 8 years ago.
Apply to 5.10
trac_13505_quasi_schur.3.patch (44.1 KB) - added by jferreira 8 years ago.
Apply to 5.11.beta3
trac_13505_quasi_schur.4.patch (44.7 KB) - added by jferreira 8 years ago.
Apply to 5.11.beta3
trac_13505-review-ts.patch (72.2 KB) - added by tscrim 8 years ago.
trac_13505_quasi_schur.5.patch (42.7 KB) - added by jferreira 8 years ago.
Apply only this one. Apply to 5.11.beta3

Download all attachments as: .zip

Change History (17)

comment:1 Changed 9 years ago by chrisjamesberg

  • Description modified (diff)

comment:2 Changed 9 years ago by chrisjamesberg

  • Owner changed from Chris Berg to chrisjamesberg

comment:3 Changed 9 years ago by jferreira

Chris,

Are you still working on this? I see the patches on the combinat server but don't see a patch here on trac for the quasisymmetric Schur functions. If you'd like to provide a patch of what you have I am happy to review it, add to it, finish it, or whatever.

-Jeff

Changed 8 years ago by jferreira

Applies cleanly to sage-5.10.rc1

comment:4 Changed 8 years ago by jferreira

  • Authors changed from Chris Berg to Chris Berg, Jeffrey Ferreira
  • Cc combinat added
  • Status changed from new to needs_review

I uploaded a patch which implements composition tableaux and quasi symmetric Schur functions. The majority of the code is from the combinat patch Chris mentions in the ticket description, except I changed the class of CompositionTableau? to more closely follow sage/combinat/tableau.py. I have also included a backtracker to help speed up iter methods.

I am working on doc strings and doing more tests of the patch, but thought it worthwhile to post the current state considering FPSAC starts next week in Pairs.

-Jeff

Changed 8 years ago by jferreira

Apply to 5.10

comment:5 Changed 8 years ago by jferreira

  • Component changed from PLEASE CHANGE to combinatorics
  • Status changed from needs_review to needs_work

Uploaded a new patch. Fixed a few edge-case bugs. Doc strings are next. I'll leave as 'needs_work' until I can get those done.

Changed 8 years ago by jferreira

Apply to 5.11.beta3

comment:6 Changed 8 years ago by jferreira

  • Description modified (diff)
  • Status changed from needs_work to needs_review

The new patch fixes some bugs and adds lots of documentation. There is nothing else I intend to add, so comments are welcome.

comment:7 Changed 8 years ago by darij

A commit message is missing. ("[mq]: port_quasi_schur.patch" is an autogenerated one. You should set a commit message manually by typing hg commit -m "trac #13505: blahblah rather than just hg commit.

On line 347, shouldn't the first > sign be an >= sign?

Changed 8 years ago by jferreira

Apply to 5.11.beta3

comment:8 Changed 8 years ago by jferreira

Thanks for the suggestions. I added a commit message and fixed the line in the documentation you referenced.

Following a suggestion from Chris Berg, I also cleaned up the all.py files so as not to pollute the global namespace.

Changed 8 years ago by tscrim

comment:9 Changed 8 years ago by tscrim

  • Dependencies set to #14101
  • Description modified (diff)
  • Reviewers changed from saliola to Travis Scrimshaw

Hey Jeff,

I've uploaded a review patch which moves the composition tableaux into its own file and does some minor cleanup of the docstrings and removing whitespace. There is a trivial dependency on #14101 in the combinat/all.py. If you're happy with my changes, go ahead and set this to positive review.

Best,
Travis

For patchbot:

Apply: trac_13505_quasi_schur.4.patch​ trac_13505-review-ts.patch​

Changed 8 years ago by jferreira

Apply only this one. Apply to 5.11.beta3

comment:10 Changed 8 years ago by jferreira

  • Description modified (diff)
  • Milestone changed from sage-6.0 to sage-5.12
  • Status changed from needs_review to positive_review

Travis,

I folded your review patch into the main patch. Thanks for your helpful edits. I had been wondering whether to pull the CompositionTableaux? classes out and into a new module, thanks for taking care of that. It does make a lot more sense to have them separate.

For patchbot:

Apply: trac_13505_quasi_schur.5.patch​

comment:11 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.12.beta5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.