Opened 9 years ago
Closed 9 years ago
#13457 closed enhancement (fixed)
Various small fixes to sage-bdist
Reported by: | jdemeyer | Owned by: | leif |
---|---|---|---|
Priority: | major | Milestone: | sage-5.4 |
Component: | scripts | Keywords: | |
Cc: | Merged in: | sage-5.4.beta2 | |
Authors: | Jeroen Demeyer | Reviewers: | John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
See patch, apply 13457_sage_bdist.patch to the scripts repository.
Attachments (1)
Change History (12)
comment:1 Changed 9 years ago by
- Summary changed from Some refactoring of sage-bdist to Various small fixes to sage-bdist
comment:2 Changed 9 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:3 Changed 9 years ago by
comment:4 Changed 9 years ago by
Fixed.
Note that the main motivation for this ticket is as prerequisite of #13123.
comment:5 Changed 9 years ago by
The new patch looks identical to the old patch.
comment:6 Changed 9 years ago by
I accidentally made the fixes to the wrong patch. I'm working on too many tickets at the same time...
comment:7 Changed 9 years ago by
Fixed (for real this time).
comment:8 Changed 9 years ago by
When I run this on OpenSolaris, I see lots of warning messages like
Copying files over to tmp directory cp: Failed to set acl entries on /export/home/palmieri/testing/sage-5.3.beta2/tmp/sage-5.3.X-i86pc-SunOS//local/include/csage cp: Failed to set acl entries on /export/home/palmieri/testing/sage-5.3.beta2/tmp/sage-5.3.X-i86pc-SunOS//local/lib/libreadline.so
As far as I can tell, the only consequence of this is that the various symbolic links in local/lib end up with new modification times. If I'm right, we can ignore the warnings. The resulting binary seems to work just fine. What do you think?
Also, the verbose flag in tar zcvf ...
is unneeded, in my opinion, although I guess it's nice to see some indication of progress while the tar.gz file is being created.
Changed 9 years ago by
comment:9 Changed 9 years ago by
I haven't looked at the OpenSolaris issues, but in any case it's not a regression of this ticket.
Agree on removing the tar v
flag, new patch needs review.
comment:10 Changed 9 years ago by
- Reviewers set to John Palmieri
- Status changed from needs_review to positive_review
Okay, good.
comment:11 Changed 9 years ago by
- Merged in set to sage-5.4.beta2
- Resolution set to fixed
- Status changed from positive_review to closed
If you feel like doing a little more:
sage-bdist
mkdir -p "$CUR/tmp""$TMP"cd "$SAGE_ROOT"The last two changes are actually crucial: you need a
cd "$SAGE_ROOT"
before line 75 because otherwise, the working directory is wrong and theif [ -d devel/sagenb ]
block doesn't execute.I'll try to keep looking at this.