source sage-env in spkg/install

[ohanar]

Currently sage environmental variables are set in both sage-env, and a subset are set in spkg/install. This should be refactored. Also, since sage-spkg is now always called from within the sage environment (as it should be), so it is no longer necessary to source sage-env.

Installation instructions:

Apply attachment:trac13448.patch​ to the root repo.

[ohanar]

The dependency is only because I don't want to rebase #13123 on this.

[ohanar]

apply to root repo

[jdemeyer]

This is going to break badly because sage-env is sourced only once (in this case, at the very beginning of the installation) but it needs to be re-sourced at various times during the installation because of environment variables which are conditionally set. This can be seen during upgrading for example, where sage-env is sourced by sage --upgrade, requiring various ugly work-arounds. To support upgrading, spkg/install needs to keep working with an old sage-env.

I agree there is a little bit of duplication between spkg/install and sage-env but I don't see a clean way to fix this. I'm open for suggestions though...

I propose to postpone this ticket, perhaps at a later time refactoring will be easier.

[ohanar]

Hmm, you are right. I'll see if I can't come up with a clean way around that, but for now we should postpone this (not really sure the best way to mark that on trac though...)

[jdemeyer]

Replying to ohanar:

not really sure the best way to mark that on trac though...

Like this?

[kini]

Typo on line 95 of sage-spkg.

[mkoeppe]

Outdated spkg or build system ticket, should be closed