Changes between Version 16 and Version 33 of Ticket #13447


Ignore:
Timestamp:
09/17/12 09:32:57 (7 years ago)
Author:
SimonKing
Comment:

I have provided a new patch, that removes the custom refcounter, using Singular's refcounter (ring.ref) instead.

As I have announced, I also fixed the failing modular symbols test, by computing the dimension before displaying it: The test previously worked only because a computation happened in a different test that happened to be executed early enough, that side effect being possible because Hecke modules would stay in memory permanently.

I did not run the full test suite yet. But sage/rings/polynomial/plural.pyx and sage/rings/polynomial/multi_polynomial_libsingular.pyx and sage/modular/modsym/ambient.py all work.

Problems for the release manager and the reviewer:

  • I removed the custom refcounting. But there were tests using the custom refcounters. The original tests demonstrated that the underlying c-data (the libsingular ring) is properly deleted. I replaced them by tests showing that the MPolynomialRing_libsingular get garbage collected. Is that OK from your point of view?
  • The mentioned tests will only work with #715 and #11521, because they are responsible for making polynomial rings garbage collectable. Hence, #13447 and #715 and #11521 need to be merged together; just having #715 and #11521 would result in the OS X problem we encountered, and #13447 alone would have two failing tests.
  • #13145 has already been merged in sage-5.4.beta1. I suggest to unmerge it, because it uses the old unreliable "double refcount" approach. My new patch also takes care of refcounting of plural rings.

Apply trac_13447-consolidated_refcount.patch trac_13447-modulus_fix.patch trac_13447-rely_on_singular_refcount.patch

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13447

    • Property Status changed from needs_info to needs_review
    • Property Report Upstream changed from Reported upstream. No feedback yet. to None of the above - read trac for reasoning.
    • Property Cc robertwb ylchapuy added
    • Property Work issues changed from Input from libsingular experts to Input from a libsingular expert
    • Property Authors changed from to Nils Bruin, Simon King
  • Ticket #13447 – Description

    v16 v33  
    33The present work-around is to permanently store references to these upon creation, thus preventing collection. It would be nice if we could properly solve the problem (or at least establish that the problem is specific to `bsd.math`)
    44
    5 Apply [attachment:trac_13447-consolidated_refcount.patch]
     5'''Unmerge''' #13145
     6
     7Apply
     8
     9 * [attachment:trac_13447-consolidated_refcount.patch]
     10 * [attachment:trac_13447-modulus_fix.patch]
     11 * [attachment:trac_13447-rely_on_singular_refcount.patch]
     12
     13'''Merge together with''' #715, #11521