Changes between Version 2 and Version 3 of Ticket #13447, comment 135


Ignore:
Timestamp:
01/13/19 19:50:08 (11 months ago)
Author:
SimonKing
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13447, comment 135

    v2 v3  
    22> Perhaps it would be better to make the libsingular and the other multivariate polynomial rings be separate tickets to have more granular changes as they are largely (completely?) independent. This already seems like a bigger ticket and the other change would likely be a bigger changeset as well.
    33
    4 Actually it isn't that big. The change of refcount does change a couple of .pxd files, but I consider the changes small. And the removal of the strong cache (commit:7c08b0) really is small.
     4Actually it isn't that big. The change of refcount does change a couple of .pxd files, but I consider the changes small. And the removal of the strong cache (commit:70c08b0) really is small.
    55
    66Therefore, splitting the ticket is not needed. But careful testing: In old attempts to fix this ticket, we saw random segfaults in doctests. I don't see them on my machine, but nonetheless it should better be tested with care on various machines. I am curious what the patchbots have to say...
     
    99
    1010Anyway, I think the ticket is now ready for review -- changes are relatively small, and tests pass, at least for me...
     11
     12EDIT: Sorry for not being able to count. I originally thought it was three commits, but there are four.