Opened 10 years ago

Closed 9 years ago

Last modified 5 years ago

#13429 closed defect (fixed)

eval_line in giac interface

Reported by: Han Frederic Owned by: William Stein
Priority: trivial Milestone: sage-5.13
Component: interfaces Keywords: giac, interface
Cc: Merged in: sage-5.13.beta3
Authors: Frederic Han Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

eval_line in the giac interface might miss the argument restart_if_needed.

The error can be seen when converting with big matrices to giac.

So I add also a doc test to see it.

NB: The other interfaces like gp,gap,axiom,maple,mathematica got the corresponding change between 4.8 and 5.0

Attachments (1)

giaceval_line.patch​ (1017 bytes) - added by Han Frederic 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by Han Frederic

Attachment: giaceval_line.patch​ added

comment:1 Changed 10 years ago by Bernard Parisse

The small change indeed fixes the conversion error.

comment:2 Changed 10 years ago by Han Frederic

Status: new → needs_review

comment:3 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11 → sage-5.12

comment:4 Changed 9 years ago by Volker Braun

Reviewers: → Volker Braun
Status: needs_review → positive_review

lgtm

comment:5 Changed 9 years ago by Han Frederic

thanks

comment:6 Changed 9 years ago by Jeroen Demeyer

Merged in: → sage-5.13.beta3
Resolution: → fixed
Status: positive_review → closed

comment:7 Changed 5 years ago by Frédéric Chapoton

Authors: Han Frederic → Frederic Han

correct name

Note: See TracTickets for help on using tickets.