Opened 9 years ago

Closed 8 years ago

Last modified 4 years ago

#13429 closed defect (fixed)

eval_line in giac interface

Reported by: frederichan Owned by: was
Priority: trivial Milestone: sage-5.13
Component: interfaces Keywords: giac, interface
Cc: Merged in: sage-5.13.beta3
Authors: Frederic Han Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

eval_line in the giac interface might miss the argument restart_if_needed.

The error can be seen when converting with big matrices to giac.

So I add also a doc test to see it.

NB: The other interfaces like gp,gap,axiom,maple,mathematica got the corresponding change between 4.8 and 5.0

Attachments (1)

giaceval_line.patch (1017 bytes) - added by frederichan 9 years ago.

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by frederichan

comment:1 Changed 9 years ago by parisse

The small change indeed fixes the conversion error.

comment:2 Changed 9 years ago by frederichan

  • Status changed from new to needs_review

comment:3 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:4 Changed 8 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

lgtm

comment:5 Changed 8 years ago by frederichan

thanks

comment:6 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.13.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 4 years ago by chapoton

  • Authors changed from Han Frederic to Frederic Han

correct name

Note: See TracTickets for help on using tickets.