Opened 8 years ago
Closed 8 years ago
#13415 closed enhancement (fixed)
Prevent unneeded rebuilding when upgrading
| Reported by: | jdemeyer | Owned by: | GeorgSWeber |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.4 |
| Component: | build | Keywords: | |
| Cc: | jhpalmieri | Merged in: | sage-5.4.beta2 |
| Authors: | Jeroen Demeyer | Reviewers: | John Palmieri |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | #13395, #13392, #13416, #12994, #9906, #12883, #13123 | Stopgaps: |
Description (last modified by )
Since (almost) every package depends on patch and bzip2, an update of either of these packages causes a rebuild of everything when upgrading.
An update of prereq even causes everything to be built twice(!) when upgrading (the new prereq script is only seen after the new root repo is installed, so the second sage-upgrade run for double-checking will install the new prereq and therefore rebuild everything).
We should simply remove dependencies of packages on PREREQ, BZIP2 and PATCH and build those packages separately.
Apply to the SAGE_ROOT repository:
- 13415_separate_base_deps_auto.patch -- automatically generated by
sed -i 's| *\$(BASE)||; s| *\$(INST)/\$(PATCH)||' spkg/standard/deps
- 13415_separate_base_deps_2.patch
Attachments (3)
Change History (21)
comment:1 Changed 8 years ago by
- Dependencies changed from #13395 to #13395, #13392
comment:2 Changed 8 years ago by
- Description modified (diff)
comment:3 Changed 8 years ago by
- Dependencies changed from #13395, #13392 to #13395, #13392, #13416
comment:4 Changed 8 years ago by
- Cc jhpalmieri added
comment:5 Changed 8 years ago by
- Description modified (diff)
comment:6 Changed 8 years ago by
- Dependencies changed from #13395, #13392, #13416 to #13395, #13392, #13416, #12994
comment:7 Changed 8 years ago by
- Dependencies changed from #13395, #13392, #13416, #12994 to #13395, #13392, #13416, #12994, #9906
comment:8 Changed 8 years ago by
comment:9 Changed 8 years ago by
I've only given the patches a quick look, but this looks like a good idea (especially after trying an update recently which updated prereq).
comment:10 Changed 8 years ago by
- Dependencies changed from #13395, #13392, #13416, #12994, #9906 to #13395, #13392, #13416, #12994, #9906, #12883
comment:11 Changed 8 years ago by
- Dependencies changed from #13395, #13392, #13416, #12994, #9906, #12883 to #13395, #13392, #13416, #12994, #9906, #12883, #13123
Changed 8 years ago by
comment:12 Changed 8 years ago by
- Status changed from new to needs_review
Changed 8 years ago by
comment:13 Changed 8 years ago by
John, any chance you could formally review this? I have tested this many times on the buildbot (together with other tickets) and it seems to work fine.
comment:14 Changed 8 years ago by
This will conflict (not much) with the changes at #10508, which basically has positive review...
comment:15 follow-up: ↓ 16 Changed 8 years ago by
- Reviewers set to John Palmieri
- Status changed from needs_review to positive_review
This looks okay to me. I think the conflicts will be easy to resolve.
comment:16 in reply to: ↑ 15 Changed 8 years ago by
Replying to jhpalmieri:
This looks okay to me. I think the conflicts will be easy to resolve.
Indeed, it's just a matter of regenerating the auto-generated patch.
comment:17 Changed 8 years ago by
Many thanks for the review!
comment:18 Changed 8 years ago by
- Merged in set to sage-5.4.beta2
- Resolution set to fixed
- Status changed from positive_review to closed
John, do you agree in principle with these patches? They are sort-of ready, but I still have to test things properly (including upgrading).