Opened 8 years ago

Closed 7 years ago

#13411 closed enhancement (fixed)

implement the Holt Graph

Reported by: chapoton Owned by: jason, ncohen, rlm
Priority: minor Milestone: sage-5.5
Component: graph theory Keywords: graph theory
Cc: Merged in: sage-5.5.beta0
Authors: Frédéric Chapoton Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by chapoton)

part of the bigger project #9136

This provides the Holt Graph

Apply:

Attachments (2)

trac_13411_holt_graph-fc.patch​ (3.2 KB) - added by chapoton 7 years ago.
with position of vertices (first try)
trac_13411-smallfix.patch​ (1.6 KB) - added by ncohen 7 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Keywords graph theory added
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by chapoton

Damn it.. It seems to depend on something about Cartesian product.

Last edited 8 years ago by chapoton (previous) (diff)

Changed 7 years ago by chapoton

with position of vertices (first try)

comment:3 Changed 7 years ago by ncohen

Hellooooooooooooo !!!!

Here is a small patch that attemtps to change that : 

sage: map(type,graphs.HoltGraph().vertices()[0])
[<type 'sage.rings.finite_rings.integer_mod.IntegerMod_int'>, <type 'sage.rings.finite_rings.integer_mod.IntegerMod_int'>]

Into the more natural product of integers. In order to avoid very weird bugs later on :-)

It also changes the layout into something slightly different.

Nathann

Changed 7 years ago by ncohen

comment:4 Changed 7 years ago by ncohen

If you agree with these changes, then this ticket is good to go ! :-)

Nathann

comment:5 Changed 7 years ago by chapoton

  • Description modified (diff)
  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

ok, and even the bot is happy ! Let's put it in positive review.

comment:6 Changed 7 years ago by chapoton

  • Description modified (diff)

comment:7 Changed 7 years ago by chapoton

  • Description modified (diff)

comment:8 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.4 to sage-5.5

comment:9 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.5.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.