Opened 8 years ago

Closed 8 years ago

#13405 closed defect (fixed)

Remove old docs when upgrading sagenb

Reported by: jdemeyer Owned by: GeorgSWeber
Priority: blocker Milestone: sage-5.3
Component: build Keywords:
Cc: Merged in: sage-5.3.rc1
Authors: Jeroen Demeyer, Keshav Kini Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

When upgrading the notebook from the pre-flask notebook, the reference manual gives WARNING because of old .rst files still present:

/release/buildbot/sage/sage-1/sage_upgrade_5.0.1/build/sage-5.4.beta0/devel/sage/doc/en/reference/sagenb/notebook/twist.rst:9: WARNING: autodoc can't import/find module 'sagenb.notebook.twist', it reported error: "No module named twist", please check your spelling and sys.path
/release/buildbot/sage/sage-1/sage_upgrade_5.0.1/build/sage-5.4.beta0/devel/sage/doc/en/reference/sagenb/simple/twist.rst:9: WARNING: autodoc can't import/find module 'sagenb.simple.twist', it reported error: "No module named web2", please check your spelling and sys.path

The solution is to delete the doc/en/reference/sagenb directory when installing the notebook.

new spkg: http://wstein.org/home/keshav/files/sagenb-0.9.2.spkg (diff: sagenb-0.9.2.diff)

Attachments (1)

sagenb-0.9.2.diff (1.6 KB) - added by jdemeyer 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by kini

Here's an SPKG: http://wstein.org/home/keshav/files/sagenb-0.9.2.spkg

These changes will be in the next SPKG for #13121 as well. Thanks!

comment:2 Changed 8 years ago by kini

Er, the SPKG is still uploading, sorry. Wait another five minutes or so I guess.

comment:3 Changed 8 years ago by jdemeyer

  • Authors set to Jeroen Demeyer, Keshav Kini
  • Description modified (diff)
  • Status changed from new to needs_review

Changed 8 years ago by jdemeyer

comment:4 Changed 8 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Are you sure this is based on the "correct" version of sagenb-0.9.1? Because I see again a bug on OpenSolaris which was supposed to be fixed:

Processing Twisted-12.1.0.tar.bz2
Running Twisted-12.1.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-V73zhs/Twisted-12.1.0/egg-dist-tmp-SnBkIT
conftest.c:1:23: error: sys/epoll.h: No such file or directory
twisted/python/sendmsg.c: In function ‘sendmsg_sendmsg’:
twisted/python/sendmsg.c:198: error: ‘struct msghdr’ has no member named ‘msg_control’
twisted/python/sendmsg.c:199: error: ‘struct msghdr’ has no member named ‘msg_controllen’
twisted/python/sendmsg.c:201: error: ‘struct msghdr’ has no member named ‘msg_flags’
twisted/python/sendmsg.c:243: warning: implicit declaration of function ‘CMSG_SPACE’
twisted/python/sendmsg.c:268: error: ‘struct msghdr’ has no member named ‘msg_control’
twisted/python/sendmsg.c:269: error: ‘struct msghdr’ has no member named ‘msg_control’
twisted/python/sendmsg.c:274: error: ‘struct msghdr’ has no member named ‘msg_control’
twisted/python/sendmsg.c:276: error: ‘struct msghdr’ has no member named ‘msg_controllen’
twisted/python/sendmsg.c:285: warning: implicit declaration of function ‘CMSG_FIRSTHDR’
twisted/python/sendmsg.c:285: warning: initialization makes pointer from integer without a cast
twisted/python/sendmsg.c:306: warning: implicit declaration of function ‘CMSG_LEN’
twisted/python/sendmsg.c:316: warning: implicit declaration of function ‘CMSG_DATA’
twisted/python/sendmsg.c:316: warning: assignment makes pointer from integer without a cast
twisted/python/sendmsg.c:322: warning: implicit declaration of function ‘CMSG_NXTHDR’
twisted/python/sendmsg.c:322: warning: assignment makes pointer from integer without a cast
twisted/python/sendmsg.c:351: error: ‘struct msghdr’ has no member named ‘msg_control’
twisted/python/sendmsg.c:352: error: ‘struct msghdr’ has no member named ‘msg_control’
twisted/python/sendmsg.c:353: error: ‘struct msghdr’ has no member named ‘msg_control’
twisted/python/sendmsg.c: In function ‘sendmsg_recvmsg’:
twisted/python/sendmsg.c:414: error: ‘struct msghdr’ has no member named ‘msg_control’
twisted/python/sendmsg.c:416: error: ‘struct msghdr’ has no member named ‘msg_controllen’
twisted/python/sendmsg.c:429: warning: assignment makes pointer from integer without a cast
twisted/python/sendmsg.c:432: warning: assignment makes pointer from integer without a cast
twisted/python/sendmsg.c:477: error: ‘struct msghdr’ has no member named ‘msg_flags’
error: Setup script exited with error: command 'gcc' failed with exit status 1
Error installing Twisted-12.1.0.tar.bz2.

comment:5 Changed 8 years ago by kini

Sorry, you're right. That bug fix was not committed properly originally so it got overwritten. Actually I don't think it really should be committed - I'll fix it the same way it was fixed on #11080. Hang on a bit...

comment:6 follow-up: Changed 8 years ago by kini

On second thought, if this same error pops up on #13121, I guess the fix is worth committing after all. We'll see. New SPKG should be up at the same URL as before in about 15 minutes (upload is really slow here in Singapore recently...).

comment:7 in reply to: ↑ 6 Changed 8 years ago by jdemeyer

Replying to kini:

On second thought, if this same error pops up on #13121

Is there any reason why it should not appear again? Why would it be magically fixed?

comment:8 Changed 8 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:9 Changed 8 years ago by kini

Sorry, I got a bit confused. There's no reason to commit it into the sagenb repo because with the new packaging the spkg-install file is no longer generated. It's tracked in the SPKG's repository, though, so I'll commit it there for #13121.

comment:10 Changed 8 years ago by jdemeyer

The packaging is good now, it installs on (Open)Solaris. Thanks for the trouble.

comment:11 Changed 8 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

The new version works for me, as long as I also update the Sage library (as recently as Sage 5.0, the file sage/doc/en/reference/notebook.rst still referred to sagenb.notebook.twist, etc.). Either failing to update the Sage library or using sagenb-0.9.1, I get the warnings about the missing imports.

comment:12 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.3.rc1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.