Opened 10 years ago

Closed 10 years ago

#13397 closed defect (fixed)

sage-location: handle lib64 also

Reported by: jdemeyer Owned by: tdb
Priority: critical Milestone: sage-5.4
Component: relocation Keywords:
Cc: Merged in: sage-5.4.beta2
Authors: Jeroen Demeyer Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

sage-location currently only handles libraries in $SAGE_LOCAL/lib, but should also look in $SAGE_LOCAL/lib32 and $SAGE_LOCAL/lib64.

Attachments (1)

13397_relocate_lib64.patch​ (2.2 KB) - added by jdemeyer 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by jdemeyer

comment:1 Changed 10 years ago by jdemeyer

  • Description modified (diff)
  • Priority changed from blocker to trivial

comment:2 Changed 10 years ago by jdemeyer

  • Description modified (diff)
  • Priority changed from trivial to critical

comment:3 Changed 10 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:4 Changed 10 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Looks good to me. (I'm not sure how this fits in with #13432; would it be worth it to recast everything in terms of SAGE_LOCAL? At the top of the file, you could do something like this: 

SAGE_ROOT      = os.path.realpath(os.environ['SAGE_ROOT'])
try:
    SAGE_LOCAL     = os.path.realpath(os.environ['SAGE_LOCAL'])
except KeyError:
    SAGE_LOCAL     = os.path.join(SAGE_ROOT, 'local')

and then use SAGE_LOCAL everywhere in the rest of the script. This belongs on another ticket, though.)

comment:5 Changed 10 years ago by jdemeyer

the SAGE_LOCAL stuff is addressed by #13452.

comment:6 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.4.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.