Changes between Version 86 and Version 97 of Ticket #13394


Ignore:
Timestamp:
11/02/13 11:51:44 (5 years ago)
Author:
SimonKing
Comment:

I have removed the trailing whitespace from the patch, but not from the branch yet (I can do so when requested).

This patch does apply to sage-5.12.beta5 (that's the latest non-git version on my machine). Note that there was a mismatch in sage/structure/factory.pyx, because someone appears to have removed trailing whitespace. It must have happened somehow between sage-5.12.beta5 and the master branch on trac, but git blame does not show how the whitespace has vanished.

Anyway. Nils, please verify that the attached patch applies to some non-git Sage, and that the patch does what we do in the branch.

Apply trac13394-weak_value_dictionary.patch

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13394

    • Property Milestone changed from sage-5.12 to sage-6.0
  • Ticket #13394 – Description

    v86 v97  
    11On ticket #12313 we found that the use of `WeakValueDictionaries` as caches can cause `removal` callbacks in rather harsh environments. Normal `WeakValueDictionaries` remove keys with dead values by looking up the key. This involves Python equality testing on the key, which can cause any kind of operation in Sage. We need a dictionary where we can delete entries without key comparisons. See below for possible strategies.
    22
    3 '''To the release manager:''' please fold this branch upon merging. There is quite a bit of back-and-forth in the history of this branch that is not very instructive to have in the global history of sage.
     3'''To the release manager:'''
     4
     5There is quite a bit of back-and-forth in the history of this branch that is not very instructive to have in the global history of sage. Hence, we have provided a single patch, if that seems to suite better. Moreover, it is in the old folder layout, so that it should be possible to apply before
     6
     7Apply [attachment:trac13394-weak_value_dictionary.patch]