#13390 closed defect (fixed)
Non Negative Integers: fix contains method
Reported by: | sstarosta | Owned by: | sstarosta |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.4 |
Component: | basic arithmetic | Keywords: | non negative integers, NonNegativeIntegers |
Cc: | hivert, vdelecroix | Merged in: | sage-5.4.beta0 |
Authors: | Štěpán Starosta | Reviewers: | Mike Hansen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
currently we have the following
sage: None in NonNegativeIntegers() True
Attachments (1)
Change History (10)
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
comment:2 follow-up: ↓ 4 Changed 10 years ago by
- Reviewers set to Mike Hansen
- Status changed from needs_review to positive_review
comment:3 Changed 10 years ago by
- Milestone changed from sage-5.3 to sage-5.4
comment:4 in reply to: ↑ 2 Changed 10 years ago by
Replying to mhansen:
You should add a doctest showing the fix works. Also, you might want to only convert to Integer once.
Thanks! I did as you suggested.
comment:5 Changed 10 years ago by
- Status changed from positive_review to needs_work
comment:6 Changed 10 years ago by
- Status changed from needs_work to needs_review
comment:7 Changed 10 years ago by
- Status changed from needs_review to positive_review
Looks good to me.
comment:8 Changed 10 years ago by
- Merged in set to sage-5.4.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
comment:9 Changed 6 years ago by
Note: See
TracTickets for help on using
tickets.
You should add a doctest showing the fix works. Also, you might want to only convert to Integer once.