Opened 9 years ago

Closed 9 years ago

Last modified 5 years ago

#13390 closed defect (fixed)

Non Negative Integers: fix contains method

Reported by: sstarosta Owned by: sstarosta
Priority: minor Milestone: sage-5.4
Component: basic arithmetic Keywords: non negative integers, NonNegativeIntegers
Cc: hivert, vdelecroix Merged in: sage-5.4.beta0
Authors: Štěpán Starosta Reviewers: Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

currently we have the following

sage: None in NonNegativeIntegers()
True

Attachments (1)

trac_13390-fix_NonNegativeIntegers.patch (764 bytes) - added by sstarosta 9 years ago.
tested on sage 5.3.beta1

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by sstarosta

  • Authors set to Stepan Starosta
  • Status changed from new to needs_review

comment:2 follow-up: Changed 9 years ago by mhansen

  • Reviewers set to Mike Hansen
  • Status changed from needs_review to positive_review

You should add a doctest showing the fix works. Also, you might want to only convert to Integer once.

comment:3 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.3 to sage-5.4

Changed 9 years ago by sstarosta

tested on sage 5.3.beta1

comment:4 in reply to: ↑ 2 Changed 9 years ago by sstarosta

Replying to mhansen:

You should add a doctest showing the fix works. Also, you might want to only convert to Integer once.

Thanks! I did as you suggested.

comment:5 Changed 9 years ago by jdemeyer

  • Status changed from positive_review to needs_work

comment:6 Changed 9 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:7 Changed 9 years ago by mhansen

  • Status changed from needs_review to positive_review

Looks good to me.

comment:8 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.4.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 5 years ago by chapoton

  • Authors changed from Stepan Starosta to Štěpán Starosta
Note: See TracTickets for help on using tickets.