Opened 9 years ago

Last modified 9 years ago

#13389 closed enhancement

Minor fix to LiE optional SPKG — at Version 6

Reported by: kini Owned by: tbd
Priority: major Milestone: sage-5.4
Component: packages: optional Keywords:
Cc: jhpalmieri Merged in:
Authors: Keshav Kini Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Change History (8)

comment:1 Changed 9 years ago by kini

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by kini

  • Description modified (diff)

comment:3 Changed 9 years ago by jhpalmieri

Also, the use of -i with sed is not portable, and breaks installation on Solaris: the file local/bin/lie still refers to the build directory. Something like this will fix it:

  • spkg-install

    diff --git a/spkg-install b/spkg-install
    a b make CC="$CC" || die "Error building LiE 
    2222
    2323# relocating
    2424cd ..
    25 sed -i -e "s'$PWD/src'$SAGE_LOCAL/lib/LiE'" src/lie
     25sed -e "s'$PWD/src'$SAGE_LOCAL/lib/LiE'" src/lie > src/lie_new
     26mv src/lie_new src/lie
    2627rm -rf "$SAGE_LOCAL"/lib/lie # clean up old versions
    2728rm -rf "$SAGE_LOCAL"/bin/lie "$SAGE_LOCAL"/lib/LiE
    2829mv src/lie "$SAGE_LOCAL"/bin/

comment:4 Changed 9 years ago by kini

I see. This is now fixed too. :)

Changed 9 years ago by kini

diff of latest commit in SPKG, for review purposes

comment:5 Changed 9 years ago by jhpalmieri

Sorry, I keep finding more issues. The file sage/interfaces/lie.py expects LiE to be installed in local/lib/lie, not local/lib/LiE. So the current setup leads to doctest failures.

Also, the file local/bin/lie should be executable. I guess this was a side effect of changing how sed was used.

Changed 9 years ago by kini

apply to $SAGE_ROOT/devel/sage

comment:6 Changed 9 years ago by kini

  • Description modified (diff)

Fixed, and added a patch to the library. I chose to use the path local/lib/LiE because it seems to be less generic than local/lib/lie and less likely to cause conflicts. Such a contingency is probably not really worthy consideration, but it is only three letters long, after all...

Note: See TracTickets for help on using tickets.