#13384 closed enhancement (fixed)
pyOpenSSL SPKG
Reported by: | kini | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-5.4 |
Component: | packages: optional | Keywords: | OpenSSL pyOpenSSL spkg |
Cc: | novoselt | Merged in: | sage-5.4.beta0 |
Authors: | Keshav Kini | Reviewers: | John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #13121 | Stopgaps: |
Description (last modified by )
pyOpenSSL 0.13 doesn't build on systems with sufficiently old OpenSSL versions. A patch exists for this but has not been included upstream. So, we have to make an SPKG.
(This SPKG continues the history of an old pyOpenSSL SPKG I found somewhere.)
Install this spkg.
Change History (25)
comment:1 Changed 10 years ago by
- Keywords OpenSSL pyOpenSSL spkg added
comment:2 Changed 10 years ago by
- Description modified (diff)
comment:3 Changed 10 years ago by
- Description modified (diff)
comment:4 Changed 10 years ago by
- Dependencies set to #13121
- Status changed from new to needs_review
comment:5 Changed 10 years ago by
- Cc novoselt added
comment:6 Changed 10 years ago by
Actually maybe we should make this an optional SPKG. It looks like we barely use OpenSSL at all - we can probably just wrap the import and handle it gracefully when pyOpenSSL isn't installed. See also William's comments a while ago here.
comment:7 Changed 10 years ago by
See #13385.
comment:8 Changed 10 years ago by
- Description modified (diff)
comment:9 Changed 10 years ago by
Keshav: the naming convention for spkgs seems to be to use lowercase almost exclusively. So I would suggest calling this "pyopenssl".
comment:11 Changed 10 years ago by
- Description modified (diff)
comment:12 Changed 10 years ago by
If we're making this an optional spkg, then we don't need to patch deps.
comment:13 Changed 10 years ago by
Yes, the attached patch was mentioned in the description before I decided this should be an optional SPKG. Now it is not mentioned in the description.
Actually now I see there's a way to delete my attachment, so I'm doing so.
comment:14 Changed 10 years ago by
Should the patch command have the form patch ... || die ...
?
Otherwise, this seems to build properly. People who have issues with old versions of OpenSSL should test it, though.
comment:15 Changed 10 years ago by
I figured applying the patch is not going to fail on someone else's system if it worked on my system. I suppose it can't hurt to add a || die
though.
Updated SPKG is at the same URL.
comment:16 Changed 10 years ago by
As I said earlier, this builds properly for me. The patch makes sense, too.
I think we have two options with this ticket: (1) Accept the spkg as is, so we can get the new notebook (etc.) merged; then if there are remaining issues with conflicting versions of OpenSSL, we can work on fixing them. (2) Try to get people who have already had issues with old versions of OpenSSL to see if this spkg fixes them.
Since this is an optional spkg, and since I don't know who to ask about option (2), I'm inclined to go with option (1). Keshav, what do you think?
comment:17 Changed 10 years ago by
Jeroen is the one to ask, as I believe this problem first came up when Jeroen was testing on a buildbot which had an old OpenSSL (OS X 10.4 I think).
But personally I'd go for (1) as I want to see #13121 and its web of dependencies get merged ASAP :)
comment:18 Changed 10 years ago by
If it's an optional package: go for it! I don't really care about OpenSSL on this OS X 10.4 machine.
Be sure to test the combination of the OpenSSL spkg with the PyOpenSSL spkg though.
comment:19 Changed 10 years ago by
- Component changed from packages to optional packages
comment:20 Changed 10 years ago by
comment:21 Changed 10 years ago by
- Reviewers set to John Palmieri
- Status changed from needs_review to positive_review
It certainly builds on top of the Sage OpenSSL package, for example on skynet/iras. Then I can load the pyOpenSSL example files and use them, although they're not very well documented, so I can't use them very much. They work without giving any errors about missing imports or bad libraries or anything like that. So I say it's ready.
comment:22 Changed 10 years ago by
- Milestone changed from sage-5.3 to sage-5.4
comment:23 Changed 10 years ago by
i just put this optional spkg on the server+mirrors.
comment:24 Changed 10 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
comment:25 Changed 10 years ago by
- Merged in set to sage-5.4.beta0
Setting this ticket to depend on #13121 because the current sagenb SPKG will overwrite this pyOpenSSL with its own internally included pyOpenSSL 0.12, making it difficult to test this SPKG.