Opened 10 years ago
Closed 9 years ago
#13377 closed defect (fixed)
Remove dead code from gen.pyx
Reported by: | nbruin | Owned by: | was |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.12 |
Component: | interfaces | Keywords: | easy, beginner, sd51 |
Cc: | Merged in: | sage-5.12.beta0 | |
Authors: | Alex Ghitza | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Attachments (1)
Change History (7)
Changed 9 years ago by
comment:1 Changed 9 years ago by
- Keywords sd51 added
- Status changed from new to needs_review
comment:2 Changed 9 years ago by
The description mentions two blocks to be removed but the patch only removes one. Why?
comment:3 Changed 9 years ago by
Ah, forgot to mention that the other block has already disappeared. You can see this by (a) looking at what happens when you apply the patch and rebuild sage--there are no other warnings about unreachable code; and/or (b) reading the very short function _coerce_c_impl
and seeing that there are no issues.
comment:4 Changed 9 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
looks good to me, positive review
comment:5 Changed 9 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:6 Changed 9 years ago by
- Merged in set to sage-5.12.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Removed the code in question.