Opened 7 years ago
Closed 7 years ago
#13369 closed enhancement (fixed)
Implementation of the class ClusterSeed
Reported by: | stumpc5 | Owned by: | sage-combinat |
---|---|---|---|
Priority: | major | Milestone: | sage-5.8 |
Component: | combinatorics | Keywords: | cluster algebra, quiver, days45 |
Cc: | Merged in: | sage-5.8.beta0 | |
Authors: | Christian Stump, Gregg Musiker | Reviewers: | Salvatore Stella |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #10538 | Stopgaps: |
Description (last modified by )
This class implements cluster seeds for skew-symmetrizable matrices.
The patch contains multiple examples.
sage: S = ClusterSeed(['A',3]); S A seed for a cluster algebra of rank 3 of type ['A', 3]
Attachments (3)
Change History (18)
comment:1 Changed 7 years ago by
- Status changed from new to needs_review
comment:2 follow-up: ↓ 5 Changed 7 years ago by
comment:3 Changed 7 years ago by
- Description modified (diff)
comment:4 Changed 7 years ago by
- Description modified (diff)
- Milestone changed from sage-5.3 to sage-5.4
comment:5 in reply to: ↑ 2 Changed 7 years ago by
Replying to gmoose05:
I just renamed and uploaded the two relevant patches without any changes.
comment:6 Changed 7 years ago by
Also, despite the patchbot's inability to apply the patches, it works fine with 5.3.rc1 on my machine (with the 10527 and 10538 patches applied first).
comment:7 Changed 7 years ago by
Both patches rebased according to the new lazy import. No other changes.
comment:8 Changed 7 years ago by
- Reviewers set to Salvatore Stella
comment:9 Changed 7 years ago by
Hi,
I updated my first patch (and uploaded Gregg's patch without changes). This resulted in some missing doctests which I then added in yet another patch. We also had some old things in the ClusterVariable class which I removed. If we need that back later, we can do it in another ticket...
Cheers, Christian
comment:10 Changed 7 years ago by
- Description modified (diff)
Changed 7 years ago by
comment:11 Changed 7 years ago by
- Description modified (diff)
Changed 7 years ago by
Changed 7 years ago by
comment:12 Changed 7 years ago by
- Status changed from needs_review to positive_review
comment:13 Changed 7 years ago by
- Milestone changed from sage-5.7 to sage-5.8
comment:14 Changed 7 years ago by
- Keywords days45 added
comment:15 Changed 7 years ago by
- Merged in set to sage-5.8.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
This was done because trac_13369-cluster_seed-cs.patch no longer applies after recent changes to 10538, although it really was only this four line conflict.
trac_13369-cluster_seed-cs-NEW.patch followed by trac_13369-cluster_seed-gm.patch,
and then the rebuilt sage passes all doc tests and appears to work correctly.