Opened 7 years ago

Closed 4 years ago

#13354 closed task (fixed)

Pass -no-undefined flag to autotool based spkg

Reported by: jpflori Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: porting: Cygwin Keywords: spkg shared library
Cc: kcrisman, dimpase Merged in:
Authors: Reviewers: Jean-Pierre Flori
Report Upstream: None of the above - read trac for reasoning. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jpflori)

A bunch of spkg using autotools do not build shared libraries of Cygwin because -no-undefined flag is not passed to libtool:

Attachments (1)

linbox-1.3.2.p0.diff (793 bytes) - added by jpflori 7 years ago.
Spkg diff, for review only.

Download all attachments as: .zip

Change History (42)

comment:1 Changed 7 years ago by jpflori

  • Description modified (diff)

comment:2 Changed 7 years ago by jpflori

Updates for

Last edited 7 years ago by jpflori (previous) (diff)

comment:3 Changed 7 years ago by jpflori

  • Description modified (diff)

comment:4 Changed 7 years ago by jpflori

  • Description modified (diff)

comment:5 Changed 7 years ago by jpflori

For the updated fixed linbox, you'll need first iml, and then updated fixed givaro together with dependencies at #12840 and #12841.

comment:6 Changed 7 years ago by jpflori

Wrong button...

Last edited 7 years ago by jpflori (previous) (diff)

comment:7 Changed 7 years ago by jpflori

The Linbox spkg from #12883 changed, so the one linked here is now outdated.

Last edited 7 years ago by jpflori (previous) (diff)

comment:8 Changed 7 years ago by jpflori

The linbox spkg is now rebased on top of #12883, but nothing is committed. By the way, the spkg there lacks an hg tag.

Changed 7 years ago by jpflori

Spkg diff, for review only.

comment:9 Changed 7 years ago by jpflori

  • Cc kcrisman dimpase added
  • Description modified (diff)

comment:10 Changed 6 years ago by jpflori

  • Description modified (diff)

comment:11 Changed 6 years ago by jpflori

  • Description modified (diff)

comment:12 Changed 6 years ago by jpflori

  • Description modified (diff)

Reported upstream for givaro, mpfi, linbox, gsl.

comment:13 Changed 6 years ago by jpflori

Reported for glpk and libfplll as well.

comment:14 Changed 6 years ago by jpflori

Contacted upstream ecm as well.

comment:15 Changed 6 years ago by jpflori

Reported for lrcalc as well.

comment:16 Changed 6 years ago by jpflori

MPFI is fixed upstream, see: https://gforge.inria.fr/scm/viewvc.php?view=rev&root=mpfi&revision=656

Givaro is fixed upstream: https://forge.imag.fr/scm/browser.php?group_id=187

I'm working on lrcalc as now Sage is more or less upstream. (I guess IML will be the same.)

And I'll provide quickly a patch for upstream ECM and it should get merged.

Feedback from fplll which I guess will be fixed in a couple of weeks in the new version (so we'll have to update to get a shared library).

Feedback from GSL and GLPK as well.

No feedback from LinBox? yet.

comment:17 Changed 6 years ago by jpflori

I've open a ticket for lrcalc, see #13839. Spkg coming soon.

comment:19 follow-up: Changed 6 years ago by kcrisman

  • Description modified (diff)

JP, if you could be sure to somehow indicate on tickets you open for this that this is the metaticket for them?

comment:20 in reply to: ↑ 19 Changed 6 years ago by jpflori

  • Description modified (diff)

Replying to kcrisman:

JP, if you could be sure to somehow indicate on tickets you open for this that this is the metaticket for them?

I'll try :)

comment:21 Changed 6 years ago by jpflori

  • Description modified (diff)
  • Report Upstream changed from N/A to None of the above - read trac for reasoning.
  • Type changed from defect to task

Libgap needs fixing as well.

comment:22 Changed 6 years ago by jpflori

  • Description modified (diff)

libgap ticket at #14038

comment:23 Changed 6 years ago by jpflori

  • Description modified (diff)
  • Status changed from new to needs_review

comment:24 Changed 6 years ago by jpflori

  • Status changed from needs_review to needs_work

comment:25 Changed 6 years ago by jpflori

  • Description modified (diff)

Tentative gsl fixed and dirty spkg which seems to let some doctests which failed before pass at http://boxen.math.washington.edu/home/jpflori/gsl-1.15.p1.spkg

comment:26 Changed 6 years ago by dimpase

As we observed on #14038, this change can break OSX. So these changes should be made CYGWIN-only, or non-OSX only. (I don't know if there is any advantage to use -no-undefined, e.g. performance-wise).

comment:27 Changed 6 years ago by jpflori

  • Description modified (diff)

GSL was #14096.

comment:28 Changed 6 years ago by jpflori

  • Description modified (diff)

libfplll has been fixed upstream in version 4.0.3.

comment:29 Changed 6 years ago by jpflori

  • Description modified (diff)

#15014 is for gf2x, this prevents building NTL on Cygwin...

comment:30 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:31 Changed 5 years ago by jpflori

For the record, the spkg needing patches are as far as I know:

  • iml
  • glpk
  • cddlib

comment:32 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:33 Changed 5 years ago by jpflori

  • Description modified (diff)

Opened #15839 for IML.

comment:35 Changed 5 years ago by jpflori

  • Description modified (diff)

Opened #15872 for cddlib.

comment:36 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:37 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:38 Changed 5 years ago by jpflori

  • Description modified (diff)

comment:39 Changed 4 years ago by jpflori

  • Description modified (diff)
  • Status changed from needs_work to positive_review

All packages we currently ship are ok upstream or configured or patched by us.

comment:40 Changed 4 years ago by jpflori

  • Reviewers set to Jean-Pierre Flori

comment:41 Changed 4 years ago by vbraun

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.