Opened 7 years ago
Closed 7 years ago
#13333 closed defect (duplicate)
Copy libpari.dll.a on Cygwin
Reported by: | jpflori | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | porting: Cygwin | Keywords: | pari spkg cygwin |
Cc: | dimpase | Merged in: | |
Authors: | Reviewers: | Dmitrii Pasechnik, Jean-Pierre Flori | |
Report Upstream: | Fixed upstream, but not in a stable release. | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #13534 | Stopgaps: |
Description (last modified by )
On Cygwin, PARI produces not only a shared library dll file but also an import dll.a file. Nonetheless, the dll.a is not copied by the install targets of the Makefile.
And having it would ensure that other shared libraries linked with -lpari would link to libpari.dll rather than libpari.a (and some as eclib won't work with libpari.a anyway, see #13325), because ld looks in order for dll.a, then a, then dll.
This has been included upstream, see git rev 2c34d58be7f844581733e7c2b96f2a60ee3eb82a and ffd02415dde8a48f7c06765635b0457b23ba60e8
Use the spkg at: http://www.infres.enst.fr/~flori/sage/pari-2.5.2.p2.spkg
Attachments (1)
Change History (21)
comment:1 follow-up: ↓ 3 Changed 7 years ago by
comment:2 Changed 7 years ago by
I'll post an updated spkg based on #13320 when this gets positive review.
comment:3 in reply to: ↑ 1 Changed 7 years ago by
Replying to jpflori:
Tentative spkg available at http://perso.telecom-paritech.fr/~flori/sage/pari-2.5.1.p4.spkg
should be http://perso.telecom-paristech.fr/~flori/sage/pari-2.5.1.p4.spkg
comment:4 Changed 7 years ago by
- Cc dimpase added
- Description modified (diff)
- Status changed from new to needs_review
Updated spkg on top of pari-2.5.2.p0 from #13320: http://perso.telecom-paristech.fr/~flori/sage/pari-2.5.2.p1.spkg
comment:5 Changed 7 years ago by
No return from upstream yet (which means some weeks now). If someone thinks the changes made here are logical, let's use the spkg at http://perso.telecom-paristech.fr/~flori/sage/pari-2.5.2.p1.spkg in Sage. At least they make sure that the shared version of Pari is found before the static one when linking (and so surely fix broken pieces of Sage) by only copying a file produced by Pari itself (the only drawback might be that linking should be a little slower, but Cygwin is already slow as hell and I did not notice any difference).
comment:6 Changed 7 years ago by
- Status changed from needs_review to needs_work
- Work issues set to Rebase on #13314
This should be rebased on top of #13314.
comment:7 Changed 7 years ago by
- Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.
- Work issues changed from Rebase on #13314 to Add PARI fix to #13314
such a change has been integrated upstream: http://pari.math.u-bordeaux.fr/archives/pari-dev-1209/msg00041.html I'll package a version of #13314 inlcuding the corresponding commit (GIT rev 2c34d58be7f8).
comment:8 Changed 7 years ago by
- Status changed from needs_work to needs_review
- Work issues Add PARI fix to #13314 deleted
New spkg including (slightly modified, because some other commits changed the patching context in between) upstream patches at: http://perso.telecom-paristech.fr/~flori/sage/pari-2.5.2.p2.spkg
comment:9 Changed 7 years ago by
- Description modified (diff)
comment:10 Changed 7 years ago by
- Description modified (diff)
comment:12 Changed 7 years ago by
- Description modified (diff)
comment:13 Changed 7 years ago by
- Milestone changed from sage-5.4 to sage-5.5
comment:14 Changed 7 years ago by
- Description modified (diff)
- Reviewers set to Dmitrii Pasechnik
comment:15 Changed 7 years ago by
- Status changed from positive_review to needs_work
comment:16 Changed 7 years ago by
I'd say let's get this merged with #13534, that's perfectly fine for me.
comment:17 Changed 7 years ago by
- Dependencies set to #13534
- Status changed from needs_work to positive_review
comment:18 Changed 7 years ago by
- Milestone changed from sage-5.5 to sage-pending
comment:19 Changed 7 years ago by
- Milestone changed from sage-pending to sage-5.5
comment:20 Changed 7 years ago by
- Milestone changed from sage-5.5 to sage-duplicate/invalid/wontfix
- Resolution set to duplicate
- Reviewers changed from Dmitrii Pasechnik to Dmitrii Pasechnik, Jean-Pierre Flori
- Status changed from positive_review to closed
Tentative spkg available at http://perso.telecom-paritech.fr/~flori/sage/pari-2.5.1.p4.spkg