Opened 7 years ago

Closed 6 years ago

#13331 closed enhancement (fixed)

Build Singular with FLINT support

Reported by: jpflori Owned by: tbd
Priority: major Milestone: sage-6.3
Component: packages: standard Keywords: singular flint spkg
Cc: burcin, jdemeyer Merged in:
Authors: Jean-Pierre Flori Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: 291e70b (Commits) Commit: 291e70b3d40026e59571ddb45c208e4ea1a1b3f1
Dependencies: #12173 Stopgaps:

Description

Once the updated FLINT 2 spkg at #12173 gets into Sage, Singular should be built with FLINT support.

Change History (23)

comment:1 follow-up: Changed 7 years ago by leif

Wonder whether Singular automatically uses FLINT if it finds the proper version (2.x?)...

Singular 3-1-5 (with our old FLINT 1.5.2) says

configure: WARNING: Unable to find FLINT (which is strongly recommended) on your machine: please use --with-flint=PATH_TO_DIR_CONTAINING_LIB_AND_INCLUDE (see also ./configure --help if you do not understand what we are talking about)

Does this ticket depend on #13237?

comment:2 in reply to: ↑ 1 Changed 7 years ago by jpflori

Replying to leif:

Does this ticket depend on #13237?

I guess it should. It should even depend on the updated spkg I'll post in a few moments in #12089 based on the one in #13237.

comment:3 Changed 7 years ago by burcin

  • Cc burcin added

comment:4 Changed 7 years ago by leif

Just to make you aware of #14737 (new spkg presumably coming up soon).

comment:5 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:6 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:7 Changed 6 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to u/jpflori/ticket/13331
  • Cc jdemeyer added
  • Status changed from new to needs_review

Modified the options passed to configured, cleaned up a little bit SPKG.txt and updated the deps file for pkgs. Added a patch so that libsingular.so and not only Singular exe is actually linked to flint. That should prevent future failure when I decide to test it under cygwin,I'll test it tonight.

comment:8 Changed 6 years ago by git

  • Commit set to 3bf4cab87623bf09068c079aaa9363c72f7feeff

Branch pushed to git repo; I updated commit sha1. New commits:

3bf4cabBuild Singular with FLINT support.

comment:9 Changed 6 years ago by fbissey

Need a refresh since we are now at singular 3.1.6.p1. As the little configuration patch been forwarded upstream?

comment:10 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:11 follow-up: Changed 6 years ago by pbruin

  • Status changed from needs_review to needs_work
  • Work issues set to does not merge with 6.2

comment:12 in reply to: ↑ 11 Changed 6 years ago by leif

Replying to pbruin:

  • Work issues set to does not merge with 6.2

Just because of #15937 or the changes to module_list.py etc.?

comment:13 Changed 6 years ago by leif

Oh, I see, it's also based on the old version of Singular, as François already mentioned.

comment:14 Changed 6 years ago by git

  • Commit changed from 3bf4cab87623bf09068c079aaa9363c72f7feeff to a54ff8991a3d6eeb08a1c95abdb99a7292efd50d

Branch pushed to git repo; I updated commit sha1. New commits:

a54ff89Merge remote-tracking branch 'trac/develop' into ticket/13331

comment:15 Changed 6 years ago by jpflori

  • Status changed from needs_work to needs_review
  • Work issues does not merge with 6.2 deleted

I did not forward the little patch upstream for two reasons:

  • I'm not sure it will be needed by Singular 4-0-0 whose build system is completely different.
  • Singular issue tracker listens on an exotic port that I cannot access from the machine I developed the patch on.

comment:16 Changed 6 years ago by pbruin

  • Reviewers set to Peter Bruin
  • Status changed from needs_review to needs_work

This seems all good except for two failing doctests where the output is a list whose ordering has changed:

sage -t --long src/doc/en/developer/coding_in_other.rst  # 1 doctest failed
sage -t --long src/doc/en/constructions/algebraic_geometry.rst  # 1 doctest failed

comment:17 Changed 6 years ago by leif

FTR/FYI:

There's a small patch at #12442 (attached, no branch) that lets Singular 3.1.6 build with clang.

comment:18 Changed 6 years ago by git

  • Commit changed from a54ff8991a3d6eeb08a1c95abdb99a7292efd50d to ff841fe98784df708b5bec5bad2108c9465ab0c0

Branch pushed to git repo; I updated commit sha1. New commits:

1c78c41Merge remote-tracking branch 'trac/develop' into ticket/13331
d45f16bLet Singular build with clang.
ff841feMerge branch 'ticket/12442' into ticket/13331

comment:19 Changed 6 years ago by git

  • Commit changed from ff841fe98784df708b5bec5bad2108c9465ab0c0 to 9c027241b60c176a3f106d903b16122c18c87e16

Branch pushed to git repo; I updated commit sha1. New commits:

9c02724Force upgrade of Singular and fix doctests on 64 bits.

comment:20 follow-up: Changed 6 years ago by jpflori

  • Status changed from needs_work to needs_review

Cannot test on 32 bits right now. Is that a job for the patchbot?


New commits:

9c02724Force upgrade of Singular and fix doctests on 64 bits.

comment:21 in reply to: ↑ 20 Changed 6 years ago by pbruin

Replying to jpflori:

Cannot test on 32 bits right now. Is that a job for the patchbot?

I don't know if anyone is running a 32-bit patchbot, but I will test it on ARM.

comment:22 Changed 6 years ago by pbruin

  • Branch changed from u/jpflori/ticket/13331 to u/pbruin/13331-singular_flint
  • Commit changed from 9c027241b60c176a3f106d903b16122c18c87e16 to 291e70b3d40026e59571ddb45c208e4ea1a1b3f1
  • Status changed from needs_review to positive_review

Fixed 32-bit doctests, I think everything should work now.

comment:23 Changed 6 years ago by vbraun

  • Branch changed from u/pbruin/13331-singular_flint to 291e70b3d40026e59571ddb45c208e4ea1a1b3f1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.