Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#13330 closed defect (fixed)

flint-1.5.2.p0.spkg installation fails on Cygwin

Reported by: jpflori Owned by: tbd
Priority: major Milestone: sage-5.3
Component: porting: Cygwin Keywords: cygwin flint spkg
Cc: Merged in: sage-5.3.beta1
Authors: Jean-Pierre Flori Reviewers: Dmitrii Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

The FLINT 1.5.2 source is a mess with regard to line terminators.

Because of that patch gets confused on Cygwin. And I found no way to produce patches that apply both on CRLF and LF line terminators systems (i.e. Cygwin and Ubuntu). Using --binary flag on Cygwin solves the problem.

Here is an updated spkg fixing that while we wait for FLINT2 of ticket #12173:

Attachments (1)

spkg.diff (1.6 KB) - added by jpflori 10 years ago.
Spkg diff, for review only.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by jpflori

  • Description modified (diff)
  • Status changed from new to needs_review
  • Work issues upload spkg deleted

Changed 10 years ago by jpflori

Spkg diff, for review only.

comment:2 Changed 10 years ago by dimpase

  • Status changed from needs_review to positive_review

Right; we fought with flint people (w00t? they develop, like, on Windows? :–)) for a while regarding these broken line endings, that confuse the hell out of Cygwin. This way it works. Positive review.

comment:3 Changed 10 years ago by jdemeyer

  • Reviewers set to Dmitrii Pasechnik

comment:4 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.3.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:5 Changed 10 years ago by jdemeyer

  • Description modified (diff)
Note: See TracTickets for help on using tickets.