Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#13329 closed defect (fixed)

Add OpenSSL prereq check

Reported by: jdemeyer Owned by: GeorgSWeber
Priority: blocker Milestone: sage-5.3
Component: build Keywords:
Cc: kini Merged in: sage-5.3.beta1
Authors: Jeroen Demeyer, Volker Braun Reviewers: Volker Braun, Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

In the prereq script, add a check for OpenSSL headers (required to build the new Sage Notebook).

Apply:

Attachments (4)

prereq-1.1.2.diff​ (6.1 KB) - added by vbraun 7 years ago.
Diff for Volker's version
prereq-1.1-reviewer.diff​ (3.2 KB) - added by jdemeyer 7 years ago.
Incremental diff, based on Volker's version
13329_sage_root.patch​ (1.3 KB) - added by jdemeyer 7 years ago.
Apply to SAGE_ROOT
prereq-1.1-libs.patch​ (1.7 KB) - added by jdemeyer 7 years ago.

Download all attachments as: .zip

Change History (21)

comment:1 Changed 7 years ago by leif

Yes, and maybe more.

comment:2 Changed 7 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)

comment:3 Changed 7 years ago by jdemeyer

  • Status changed from new to needs_review

Changed 7 years ago by vbraun

Diff for Volker's version

comment:4 Changed 7 years ago by vbraun

  • Authors changed from Jeroen Demeyer to Jeroen Demeyer, Volker Braun
  • Description modified (diff)
  • Reviewers set to Volker Braun

As I said on the mailinglist, I think its good to also check for dpkg-architecture. I've also added checks for the OpenSSL library and some misc. I'm fine with Jeroen's changes, of course.

Changed 7 years ago by jdemeyer

Incremental diff, based on Volker's version

comment:5 Changed 7 years ago by jdemeyer

  • Description modified (diff)
  • Reviewers changed from Volker Braun to Volker Braun, Jeroen Demeyer

Volker, I made some further changes. If you're happy with these, you can set the whole ticket to positive_review.

comment:6 Changed 7 years ago by vbraun

  • Status changed from needs_review to positive_review

Looks good!

comment:7 Changed 7 years ago by kini

  • Cc kini added

comment:8 Changed 7 years ago by jdemeyer

  • Status changed from positive_review to needs_work

In some cases, we need to add -lcrypto -ldl for OpenSSL to link correctly.

comment:9 Changed 7 years ago by jdemeyer

Another issue: prereq doesn't actually check SAGE_LOCAL/lib, since sage-env wasn't sourced. Fixed in the new SAGE_ROOT patch.

Last edited 7 years ago by jdemeyer (previous) (diff)

comment:10 Changed 7 years ago by jdemeyer

  • Description modified (diff)

comment:11 Changed 7 years ago by jdemeyer

  • Dependencies set to #13348

comment:12 Changed 7 years ago by jdemeyer

  • Dependencies #13348 deleted

comment:13 Changed 7 years ago by jdemeyer

Actually, sourcing sage-env doesn't help because using the LIBRARY_PATH environment variable isn't very portable.

Changed 7 years ago by jdemeyer

Apply to SAGE_ROOT

Changed 7 years ago by jdemeyer

comment:14 Changed 7 years ago by jdemeyer

  • Status changed from needs_work to needs_review

In the end, I reverted the SAGE_ROOT patch to the one which got positive_review already.

I added prereq-1.1-libs.patch​ to the prereq configure script, needs review.

comment:15 Changed 7 years ago by vbraun

  • Status changed from needs_review to positive_review

looks good to me

comment:16 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.3.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:17 Changed 7 years ago by kini

If ​sage-devel decides #13385 is a good idea, we would have to undo part of this, namely the check for OpenSSL dev headers that titles this ticket.

Note: See TracTickets for help on using tickets.