#13329 closed defect (fixed)
Add OpenSSL prereq check
| Reported by: | jdemeyer | Owned by: | GeorgSWeber |
|---|---|---|---|
| Priority: | blocker | Milestone: | sage-5.3 |
| Component: | build | Keywords: | |
| Cc: | kini | Merged in: | sage-5.3.beta1 |
| Authors: | Jeroen Demeyer, Volker Braun | Reviewers: | Volker Braun, Jeroen Demeyer |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
In the prereq script, add a check for OpenSSL headers (required to build the new Sage Notebook).
Apply:
- to SAGE_ROOT: 13329_sage_root.patch
- copy the new prereq tarball into
spkg/base: http://boxen.math.washington.edu/home/jdemeyer/spkg/prereq-1.1.tar.gz (changes for review: prereq-1.1.2.diff and prereq-1.1-reviewer.diff and prereq-1.1-libs.patch)
Attachments (4)
Change History (21)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
- Description modified (diff)
comment:3 Changed 10 years ago by
- Status changed from new to needs_review
comment:4 Changed 10 years ago by
- Description modified (diff)
- Reviewers set to Volker Braun
As I said on the mailinglist, I think its good to also check for dpkg-architecture. I've also added checks for the OpenSSL library and some misc. I'm fine with Jeroen's changes, of course.
comment:5 Changed 10 years ago by
- Description modified (diff)
- Reviewers changed from Volker Braun to Volker Braun, Jeroen Demeyer
Volker, I made some further changes. If you're happy with these, you can set the whole ticket to positive_review.
comment:7 Changed 10 years ago by
- Cc kini added
comment:8 Changed 10 years ago by
- Status changed from positive_review to needs_work
In some cases, we need to add -lcrypto -ldl for OpenSSL to link correctly.
comment:9 Changed 10 years ago by
Another issue: prereq doesn't actually check SAGE_LOCAL/lib, since sage-env wasn't sourced. Fixed in the new SAGE_ROOT patch.
comment:10 Changed 10 years ago by
- Description modified (diff)
comment:11 Changed 10 years ago by
- Dependencies set to #13348
comment:12 Changed 10 years ago by
- Dependencies #13348 deleted
comment:13 Changed 10 years ago by
Actually, sourcing sage-env doesn't help because using the LIBRARY_PATH environment variable isn't very portable.
Changed 10 years ago by
comment:14 Changed 10 years ago by
- Status changed from needs_work to needs_review
In the end, I reverted the SAGE_ROOT patch to the one which got positive_review already.
I added prereq-1.1-libs.patch to the prereq configure script, needs review.
comment:15 Changed 10 years ago by
- Status changed from needs_review to positive_review
looks good to me
comment:16 Changed 10 years ago by
- Merged in set to sage-5.3.beta1
- Resolution set to fixed
- Status changed from positive_review to closed
comment:17 Changed 10 years ago by
If sage-devel decides #13385 is a good idea, we would have to undo part of this, namely the check for OpenSSL dev headers that titles this ticket.
Yes, and maybe more.