Opened 9 years ago

Closed 9 years ago

#13320 closed enhancement (fixed)

Upgrade to PARI-2.5.2

Reported by: jdemeyer Owned by: tbd
Priority: major Milestone: sage-5.3
Component: packages: standard Keywords:
Cc: jpflori Merged in: sage-5.3.beta2
Authors: Jeroen Demeyer Reviewers: Marco Streng
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: to be merged with #12346 Stopgaps:

Status badges

Attachments (1)

pari-2.5.2.p0.diff (12.5 KB) - added by jdemeyer 9 years ago.
Diff for the PARI spkg. For reference / review only.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 9 years ago by jdemeyer

  • Dependencies set to to be merged with #12346

There is one doctest failure due to a bug being fixed, see #12346.

comment:3 Changed 9 years ago by jpflori

  • Cc jpflori added

comment:4 Changed 9 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from new to needs_review

Changed 9 years ago by jdemeyer

Diff for the PARI spkg. For reference / review only.

comment:5 Changed 9 years ago by jdemeyer

Tested on the buildbots, no problems.

comment:6 follow-up: Changed 9 years ago by mstreng

  • Reviewers set to Marco Streng

why remove the "Files previously patched" section when someone (you?) explicitly wrote "Do not delete that!"? Also, did David Kirkby's note become irrelevant?

I did not test, but the release manager said on sage-devel that we could trust that the author tested this ticket thoroughly ;)

So I'll just wait for Jeroen to answer these questions and then set this to positive review.

comment:7 in reply to: ↑ 6 Changed 9 years ago by jdemeyer

Replying to mstreng:

why remove the "Files previously patched" section when someone (you?) explicitly wrote "Do not delete that!"?

I certainly did not add the "files previously patched" section, not ask that it doesn't get deleted. I removed it because

  1. it causes me more effort than needed when removing a patch.
  2. those who want to see previous patches can always check the Mercurial history or download an older version of Sage.
  3. it's not even clear why we should keep a record of those historical patches in that file.

Also, did David Kirkby's note become irrelevant?

Yes. The flags in that comment are no longer added by upstream PARI and the workaround isn't needed.

I did not test, but the release manager said on sage-devel that we could trust that the author tested this ticket thoroughly ;)

I did indeed test this as much as I could.

comment:8 Changed 9 years ago by mstreng

  • Status changed from needs_review to positive_review

comment:9 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.3.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.