Clean up MANIFEST.in, spkg-delauto and spkg-dist

[jdemeyer]

There are some obvious improvements and simplifications to be done to devel/sage/MANIFEST.in and devel/sage/spkg-dist.

Apply 13315_manifest.patch​

[jdemeyer]

I tested this patch by creating a new sdist (starting from sage-5.2), and these are the only differences in files being added or not (this is the diff of ls -a1RF output):

sage-5.2.

@@ -30 +30 @@
 branch
 branch.cache
 branchheads.cache
+cache/
 dirstate
 hgrc
 last-message.txt
@@ -41 +42 @@
 undo.desc
 undo.dirstate
 
+./.hg/cache:
+./
+../
+branchheads
+tags
+
 ./.hg/store:
 ./
 ../
@@ -49 +56 @@
 00manifest.d
 00manifest.i
 data/
+fncache
+phaseroots
+undo
+undo.phaseroots
 
 ./.hg/store/data:
 ./
@@ -5178 +5189 @@
 ./c_lib:
 ./
 ../
-.sconsign.dblite
 SConstruct
 include/
 src/

[jhpalmieri]

At first glance this seems okay to me. But why not more clean up, for example

MANIFEST.in

@@ -1 @@
-recursive-include * *.c *.cc *.cpp *.h *.hh *.hpp *.pyx *.pxd *.pxi *.txt *.tex
-recursive-include doc *.rst *.py *.inc
+global-include *.c *.cc *.cpp *.h *.hh *.hpp *.py  *.pyx *.pxd *.pxi *.txt *.tex
+recursive-include doc *.rst *.inc
 graft .hg
 include .hgignore .hgtags
 include MANIFEST.in
 include bundle export install pull sage-push
-include module_list.py
-include fpickle_setup.py
 include spkg-delauto spkg-dist spkg-install
 include c_lib/SConstruct
 include sage/ext/mac-app/README
 include sage/graphs/graph_decompositions/rankwidth_c/README
-include sage/libs/gmp/__init__.py
-include sage/libs/polybori/__init__.py
-include sage/numerical/test.py
-include sage/rings/polynomial/padics/__init__.py
 include sage/schemes/hyperelliptic_curves/hypellfrob/README
-include sage/server/notebook/templates/*
-include sage/server/notebook/templates/css/*
-include sage/server/notebook/templates/notebook/*
-include sage/server/notebook/templates/worksheet/*
 include sage/tests/french_book/README
+graft sage/server/notebook/templates
+graft sage/server/notebook/templates/css
+graft sage/server/notebook/templates/notebook
+graft sage/server/notebook/templates/worksheet
 include doc/common/python.inv
 include doc/common/update-python-inv.sh
 include doc/en/introspect/static/empty
 include doc/en/introspect/templates/layout.html
-include doc/en/numerical_sage/errors
 include doc/en/website/static/pdf.png
 include doc/en/website/templates/index.html
 include doc/en/a_tour_of_sage/eigen_plot.png

(Why do we include doc/en/numerical_sage/errors? Why don't we include all *.py files?)

[jhpalmieri]

Also, regarding line 22 of spkg-dist:

	cp -pR .hg* doc sage c_lib tmp/

copying the entire doc directory can take a while, since we're copying all of the output. Would it be better to copy doc/common and doc/[a-z][a-z]?

[jdemeyer]

Good points.

[jhpalmieri]

In line 1 of MANIFEST.in, should we replace recursive-include * ... with global-include ...? Then I think we can delete line 8 (include fpickle_setup.py module_list.py). In my testing, the results are the same with these changes.

[jhpalmieri]

Okay, this looks good to me.