Opened 8 years ago

Closed 8 years ago

#13310 closed defect (fixed)

`:trac:` links are broken

Reported by: ppurka Owned by: mvngu
Priority: major Milestone: sage-5.3
Component: documentation Keywords: trac keyword
Cc: Merged in: sage-5.3.beta1
Authors: John Palmieri Reviewers: Punarbasu Purkayastha
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jhpalmieri)

Two issues:

  1. The use of :trac:`<number>` is broken on the command line. The second link below shouldn't repeat the ticket number of the first one
    sage: integral?
    <removed earlier text>
           TESTS:
    
           A symbolic integral from http://trac.sagemath.org/11445 that was
           incorrect in earlier versions of Maxima:
    
              sage: f = abs(x - 1) + abs(x + 1) - 2*abs(x)
              sage: integrate(f, (x, -Infinity, Infinity))
              2
    
           Another symbolic integral, from http://trac.sagemath.org/11445,
           that used to return zero incorrectly:
    
              sage: f = exp(-x) * sinh(sqrt(x))
              sage: integrate(f, x, 0, Infinity)
              1/2*sqrt(pi)*e^(1/4)
    
  2. reported upstream. The link in the notebook is actually correct (that is I get the correct ticket number in the second URL), but it should open the documentation in a new tab. Otherwise, there is a huge potential of someone losing all their work just because they forgot to shift-click or something.

#13116 fixed trac tickets in docstrings for command line, but I think it wasn't fixed properly. The problem exists at least as far back as sage-5.1.rc0.


Apply trac_13310-trac.patch

Attachments (1)

trac_13310-trac.patch (1.9 KB) - added by jhpalmieri 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by jhpalmieri

  • Authors set to John Palmieri
  • Status changed from new to needs_review

I think that these are two completely separate issue, and deserve completely separate tickets. In fact, issue 2 is really an issue with the notebook, so should be dealt with upstream. I'm attaching a patch for issue 1.

comment:2 Changed 8 years ago by jhpalmieri

(By the way, I think that the sagenb issue could be fixed by patching the "sphinxify" function, but it should be done at the sagenb github site, not here.)

comment:3 Changed 8 years ago by ppurka

  • Description modified (diff)
  • Reviewers set to Punarbasu Purkayastha
  • Status changed from needs_review to positive_review

This works. Thanks. Issue 2 is reported upstream.

comment:4 Changed 8 years ago by ppurka

Hmm... the patch does not end with the correct extension, hopefully it is not a problem.

patchbot apply trac_13310-trac.pach

comment:5 Changed 8 years ago by jhpalmieri

  • Description modified (diff)

It shouldn't be a problem, but just in case...

Changed 8 years ago by jhpalmieri

comment:6 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.3.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.