Opened 8 years ago
Closed 8 years ago
#13310 closed defect (fixed)
`:trac:` links are broken
Reported by: | ppurka | Owned by: | mvngu |
---|---|---|---|
Priority: | major | Milestone: | sage-5.3 |
Component: | documentation | Keywords: | trac keyword |
Cc: | Merged in: | sage-5.3.beta1 | |
Authors: | John Palmieri | Reviewers: | Punarbasu Purkayastha |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Two issues:
- The use of
:trac:`<number>`
is broken on the command line. The second link below shouldn't repeat the ticket number of the first onesage: integral? <removed earlier text> TESTS: A symbolic integral from http://trac.sagemath.org/11445 that was incorrect in earlier versions of Maxima: sage: f = abs(x - 1) + abs(x + 1) - 2*abs(x) sage: integrate(f, (x, -Infinity, Infinity)) 2 Another symbolic integral, from http://trac.sagemath.org/11445, that used to return zero incorrectly: sage: f = exp(-x) * sinh(sqrt(x)) sage: integrate(f, x, 0, Infinity) 1/2*sqrt(pi)*e^(1/4)
- reported upstream. The link in the notebook is actually correct (that is I get the correct ticket number in the second URL), but it should open the documentation in a new tab. Otherwise, there is a huge potential of someone losing all their work just because they forgot to shift-click or something.
#13116 fixed trac tickets in docstrings for command line, but I think it wasn't fixed properly. The problem exists at least as far back as sage-5.1.rc0.
Apply trac_13310-trac.patch
Attachments (1)
Change History (7)
comment:1 Changed 8 years ago by
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
(By the way, I think that the sagenb issue could be fixed by patching the "sphinxify" function, but it should be done at the sagenb github site, not here.)
comment:3 Changed 8 years ago by
- Description modified (diff)
- Reviewers set to Punarbasu Purkayastha
- Status changed from needs_review to positive_review
This works. Thanks. Issue 2 is reported upstream.
comment:4 Changed 8 years ago by
Hmm... the patch does not end with the correct extension, hopefully it is not a problem.
patchbot apply trac_13310-trac.pach
comment:5 Changed 8 years ago by
- Description modified (diff)
It shouldn't be a problem, but just in case...
Changed 8 years ago by
comment:6 Changed 8 years ago by
- Merged in set to sage-5.3.beta1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I think that these are two completely separate issue, and deserve completely separate tickets. In fact, issue 2 is really an issue with the notebook, so should be dealt with upstream. I'm attaching a patch for issue 1.