Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13298 closed enhancement (fixed)

Update Cremona's table of elliptic curves to 270000

Reported by: cremona Owned by: was
Priority: minor Milestone: sage-5.4
Component: packages: optional Keywords: Elliptic curves
Cc: ohanar Merged in: sage-5.4.beta1
Authors: John Cremona Reviewers: R. Andrew Ohana
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by cremona)

On 2012-08-27 John Cremona published an update of his database covering conductors up to 270000. The optional spkg database_cremona_ellcurve needs updating accordingly.

Updated spkg: http://homepages.warwick.ac.uk/staff/J.E.Cremona/ftp/database_cremona_ellcurve-20120827.spkg

Attachments (1)

trac_13298-elliptic-curve.patch (1.3 KB) - added by cremona 8 years ago.
Applies to 5.3.beta0

Download all attachments as: .zip

Change History (20)

comment:1 Changed 8 years ago by cremona

  • Description modified (diff)

comment:2 Changed 8 years ago by cremona

As soon as I have finished a full test to see if any doctests need changing (as sometimes happens) I'll set this to Needs Review.

comment:3 Changed 8 years ago by cremona

  • Status changed from new to needs_review

This works as is with 5.2.rc1. After #12768 there will need to be one doctest change in sage/schemes/elliptic_curves/ell_curve_isogeny.py since #12768 introduces a doctest which creates a curve whose conductor is between 240k and 250k.

comment:4 Changed 8 years ago by jdemeyer

Please fill in your real name as Author.

comment:5 Changed 8 years ago by cremona

  • Authors set to John Cremona

comment:6 Changed 8 years ago by cremona

  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Summary changed from Update Cremona's table of elliptic curves to 250000 to Update Cremona's table of elliptic curves to 270000

comment:7 Changed 8 years ago by cremona

  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:8 Changed 8 years ago by cremona

  • Status changed from needs_review to needs_work

I'm now making a patch to allow for the issue raised above relating to #12768.

Changed 8 years ago by cremona

Applies to 5.3.beta0

comment:9 Changed 8 years ago by cremona

  • Status changed from needs_work to needs_review

Without the patch there's one test which will fail if the optional database is installed since it relies on a curve of conductor 10001 not being in the database. I replaced it by one of conductor >10^8.

comment:10 Changed 8 years ago by cremona

  • Cc ohanar added

comment:11 Changed 8 years ago by ohanar

  • Reviewers set to R. Andrew Ohana
  • Status changed from needs_review to positive_review

looks good

comment:12 Changed 8 years ago by jdemeyer

  • Component changed from databases to optional packages

comment:13 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.3 to sage-5.4

comment:14 Changed 8 years ago by schilly

spkg is on the sage server + on its way around the world :)

comment:15 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.4.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:16 follow-up: Changed 8 years ago by cremona

Thanks! I was wondering if I would get to 280000 before this went in, but no (currently at 275840).

comment:17 in reply to: ↑ 16 ; follow-up: Changed 8 years ago by cremona

Replying to cremona:

Thanks! I was wondering if I would get to 280000 before this went in, but no (currently at 275840).

I now have an updated spkg which goes up to 280000. Shall I open a new ticket for that (I assume yes)?

comment:18 in reply to: ↑ 17 ; follow-up: Changed 8 years ago by schilly

Replying to cremona:

I now have an updated spkg which goes up to 280000. Shall I open a new ticket for that (I assume yes)?

Yes please! It's more work, but hard to follow later on, if one ticket that has been closed (and resolved something) ends up serving more than one task.

comment:19 in reply to: ↑ 18 Changed 8 years ago by cremona

Replying to schilly:

Replying to cremona:

I now have an updated spkg which goes up to 280000. Shall I open a new ticket for that (I assume yes)?

Yes please! It's more work, but hard to follow later on, if one ticket that has been closed (and resolved something) ends up serving more than one task.

Fine. See #13547.

Note: See TracTickets for help on using tickets.