Opened 8 years ago

Closed 6 years ago

#13291 closed enhancement (fixed)

Make matlab optional tests consistent

Reported by: kcrisman Owned by: mvngu
Priority: trivial Milestone: sage-6.3
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: 661ff04 (Commits) Commit: 661ff0489b6730caae7766a000664c1dc02498f6
Dependencies: Stopgaps:

Description

The tests in sage/interfaces/matlab.py are somewhat inconsistent in how they indicate their "optionalness" right now. Let's make that better, and consistent with the new way of doing it. Also one or two of them are actually doable without Matlab! So let's make that work, too.

Change History (8)

comment:1 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:2 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:3 Changed 6 years ago by chapoton

  • Branch set to u/chapoton/13291
  • Commit set to 2e05b56f4d9a217b66616d0fdca3d2bb4cccd7d8
  • Status changed from new to needs_review

Here is a git branch.

I have written 'optional - matlab' everywhere

and corrected a few raise statements into python3 format

and change a few details towards python3

I have not found the tests that could run without matlab.

New commits:

​2e05b56trac #13291 formatting as 'optional - matlab'

comment:4 Changed 6 years ago by chapoton

  • Authors set to Frédéric Chapoton

comment:5 Changed 6 years ago by git

  • Commit changed from 2e05b56f4d9a217b66616d0fdca3d2bb4cccd7d8 to 661ff0489b6730caae7766a000664c1dc02498f6

Branch pushed to git repo; I updated commit sha1. New commits:

​661ff04Merge branch 'u/chapoton/13291' of ssh://trac.sagemath.org:22/sage into 13291

comment:6 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:7 Changed 6 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

Looks good to me. I couldn't run the optional tests (no matlab available). But since only comments have been changed there, I suppose test results will stay the same.

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/chapoton/13291 to 661ff0489b6730caae7766a000664c1dc02498f6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.