Opened 10 years ago

Closed 8 years ago

#13276 closed defect (fixed)

Add CDF._factor_univariate_polynomial()

Reported by: saraedum Owned by: AlexGhitza
Priority: minor Milestone: sage-6.2
Component: basic arithmetic Keywords: beginner
Cc: Merged in:
Authors: Julian Rueth Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: ce12073 (Commits, GitHub, GitLab) Commit: ce12073c2fc0c5bb031fa79d94d395be433b6a50
Dependencies: #13275 Stopgaps:

Status badges

Description

As a part of #11731, transfer the code which does the factorization over CDF and RDF from sage.rings.polynomial.polynomial_element.Polynomial.factor() to CDF._factor_univariate_polynomial() and RDF._factor_univariate_polynomial() respectively.

This will also fix the following bug:

sage: R.<x> = CDF[]
sage: (x^2).factor()
AssertionError

Attachments (1)

trac_13276.patch (8.1 KB) - added by saraedum 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by saraedum

comment:1 Changed 10 years ago by saraedum

  • Authors set to Julian Rueth
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by pbruin

  • Reviewers set to Peter Bruin

comment:3 Changed 9 years ago by asalerno

  • Status changed from needs_review to needs_work

This patch depends on #13274, which no longer applies to Sage 5.10.rc1.

comment:4 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:5 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 8 years ago by pbruin

  • Branch set to u/pbruin/13276-CDF_factor_univariate_polynomial
  • Commit set to ce12073c2fc0c5bb031fa79d94d395be433b6a50
  • Status changed from needs_work to positive_review

Converted patch to a Git branch, only trivial merge conflicts and whitespace edits. Looks good, all test pass.

comment:7 Changed 8 years ago by vbraun

  • Branch changed from u/pbruin/13276-CDF_factor_univariate_polynomial to ce12073c2fc0c5bb031fa79d94d395be433b6a50
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.