Opened 10 years ago

Closed 8 years ago

#13275 closed task (fixed)

Add QQbar._factor_univariate_polynomial()

Reported by: saraedum Owned by: malb
Priority: trivial Milestone: sage-6.2
Component: commutative algebra Keywords: beginner
Cc: Merged in:
Authors: Julian Rueth Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: cd6dd44 (Commits, GitHub, GitLab) Commit: cd6dd4410085f2029ef0c22c400a3c379c1d6b7f
Dependencies: #13274 Stopgaps:

Status badges


As a part of #11731, transfer the code which does the factorization over QQbar and AA from sage.rings.polynomial.polynomial_element.Polynomial.factor() to QQbar._factor_univariate_polynomial() and AA._factor_univariate_polynomial() respectively.

Attachments (1)

trac_13275.patch (8.4 KB) - added by saraedum 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by saraedum

comment:1 Changed 10 years ago by saraedum

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by pbruin

  • Reviewers set to Peter Bruin

comment:3 Changed 9 years ago by christelle

  • Status changed from needs_review to needs_work

See ticket #13274; doesn't apply correctly to 5.10.

comment:4 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:5 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 8 years ago by pbruin

  • Branch set to u/pbruin/13275-QQbar_factor_univariate_polynomial
  • Commit set to cd6dd4410085f2029ef0c22c400a3c379c1d6b7f
  • Status changed from needs_work to positive_review

Converted patch to a Git branch, only trivial merge conflicts and whitespace edits. Looks good, all test pass.

New commits:

cd6dd44Added _factor_univariate_polynomial() for QQbar and AA

comment:7 Changed 8 years ago by vbraun

  • Branch changed from u/pbruin/13275-QQbar_factor_univariate_polynomial to cd6dd4410085f2029ef0c22c400a3c379c1d6b7f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.